-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix if:
scope option with lambdas
#5501
Conversation
if:
scope option with lambdas
f60c3cc
to
1e91f85
Compare
Codecov Report
@@ Coverage Diff @@
## master #5501 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 296 296
Lines 10928 10928
=======================================
Hits 10818 10818
Misses 110 110
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearer if first two commits are squashed, I think.
@deivid-rodriguez if you do squash those related commits and push it'll get rid of the review so ping me and I'll approve this again for you! |
Yeah, I'll squash them! I think I could squash the three of them actually? |
1e91f85
to
ab9afb8
Compare
Everything squashed! |
…mbdas Fix `if:` scope option with lambdas (cherry picked from commit f7f863a)
Fixes #5494.