Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix if: scope option with lambdas #5501

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix if: scope option with lambdas #5501

merged 1 commit into from
Oct 8, 2018

Conversation

deivid-rodriguez
Copy link
Member

Fixes #5494.

@deivid-rodriguez deivid-rodriguez changed the title Fix if scope option with lambdas Fix if: scope option with lambdas Oct 6, 2018
@deivid-rodriguez deivid-rodriguez mentioned this pull request Oct 6, 2018
Closed
javierjulio
javierjulio previously approved these changes Oct 6, 2018
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 6, 2018 •
edited
Loading

Codecov Report

Merging #5501 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5501   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         296      296           
  Lines       10928    10928           
=======================================
  Hits        10818    10818           
  Misses        110      110
Impacted Files Coverage Δ
lib/active_admin/views/components/scopes.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2f195...ab9afb8. Read the comment docs.

@deivid-rodriguez deivid-rodriguez mentioned this pull request Oct 7, 2018
Merged
varyonic
varyonic previously approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@varyonic varyonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearer if first two commits are squashed, I think.

@javierjulio
Copy link
Member

@deivid-rodriguez if you do squash those related commits and push it'll get rid of the review so ping me and I'll approve this again for you!

@deivid-rodriguez
Copy link
Member Author

Yeah, I'll squash them! I think I could squash the three of them actually?

@deivid-rodriguez
Copy link
Member Author

Everything squashed!

@javierjulio javierjulio merged commit f7f863a into master Oct 8, 2018
@deivid-rodriguez deivid-rodriguez deleted the fix_if_scope_option_with_lambdas branch October 8, 2018 18:32
deivid-rodriguez pushed a commit that referenced this pull request Nov 14, 2018
@javierjulio @deivid-rodriguez
Merge pull request #5501 from activeadmin/fix_if_scope_option_with_la…
3a2c63f 
…mbdas

Fix `if:` scope option with lambdas

(cherry picked from commit f7f863a)
@deivid-rodriguez deivid-rodriguez mentioned this pull request Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

@varyonic varyonic varyonic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deivid-rodriguez @javierjulio @varyonic