Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set custom content to page head #5590

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

buren
Copy link
Contributor

@buren buren commented Nov 23, 2018

My use case is that I want to be able to add custom content to the <head> tag. Could be scripts like Google Analytics etc.

It adds ActiveAdmin.application.head and follows the same configuration pattern as footer.

Fivell
Fivell previously approved these changes Dec 2, 2018
timoschilling
timoschilling previously approved these changes Dec 24, 2018
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this! Can you add a change log entry?

@buren buren dismissed stale reviews from timoschilling and Fivell via 77108dd December 24, 2018 16:49
buren added a commit to justarrived/just_match_api that referenced this pull request Dec 25, 2018
buren added a commit to justarrived/just_match_api that referenced this pull request Dec 25, 2018
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@buren
Copy link
Contributor Author

buren commented Dec 27, 2018

@deivid-rodriguez I'll rebase this against master.

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of extra comments, sorry I didn't notice those before.

features/head.feature Show resolved Hide resolved
features/head.feature Outdated Show resolved Hide resolved
@buren
Copy link
Contributor Author

buren commented Dec 27, 2018

@deivid-rodriguez rebased against master and have fixed your comments 👍
Thank you for reviewing this 👑

@deivid-rodriguez deivid-rodriguez requested a review from a team January 3, 2019 08:32
@deivid-rodriguez
Copy link
Member

Going in!

@deivid-rodriguez deivid-rodriguez merged commit 8f06e44 into activeadmin:master Jan 3, 2019
@buren buren deleted the head-namespace-setting branch January 3, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants