Update templates and dark mode styles #8187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierjulio
force-pushed
the
main-navigation
branch
from
c23a294
to
d5da545
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8187 +/- ##
==========================================
- Coverage 99.03% 99.03% -0.01%
==========================================
Files 151 151
Lines 4164 4150 -14
==========================================
- Hits 4124 4110 -14
Misses 40 40 ☔ View full report in Codecov by Sentry. |
javierjulio
force-pushed
the
main-navigation
branch
from
3789e8a
to
272083f
Compare
This is a work in progress.
This adds some min widths and truncates the comment body.
We were setting default background color but its not needed since we prefer to take on the inherited background color and just apply an explicit background color on hover.
Since these are not used by the paginator we can safely delete these. Forgot to do so when combining the two original themes we had (active_admin and active_admin_countless) for a simpler, modern pagination layout.
This way we can style the default breadcrumbs from the view with Tailwind classes. If providing custom breadcrumb, since full links are given, caller should provide any classes for styling. This improves colors for light and dark modes.
javierjulio
force-pushed
the
main-navigation
branch
2 times, most recently
from
07f07c9
to
fafd67c
Compare
javierjulio
changed the title
Still some elements to update with better dark mode styles but this gets most of the contents on the page. Updated the main navigation layout and hover/selected states. Updated the data-table and attributes-table styles, not just dark mode but spacing, borders and other styles. Imrpoved the empty-value style for all modes too.
javierjulio
force-pushed
the
main-navigation
branch
from
fafd67c
to
896762f
Compare
The content was going off screen due to h-screen usage. This was fine originally since we had the menu always be full screen vertically but we've changed that now so have to adjust the top offset based on breakpoint.
Otherwise these styles are purged which we don't want.
Use whitespace nowrap so multi word status tags don't wrap in a table. Use pill shaped badges instead. No need to duplicate styles here since the second selector is just for updating the color based on the data attribute.
This will be required for now with cssbundling-rails. Another option is to copy and paste the plugin.js file to the host app and run it and it will work. That could be an option for tailwindcss-rails users. At the moment there isn't another alternative. I've tried requiring the plugin from the gem path but it doens't seem that Tailwind can find its own modules if required that way. It has to be local.
javierjulio
force-pushed
the
main-navigation
branch
from
896762f
to
e1d659d
Compare
Originally, we needed this as we didn't extract other views in the layout to partials. No need for specific partials now since chances are if someone wants to edit this, they will want to edit most of the HTML head anyway so easier to extract a single partial with everything already there as its not that many lines. Since we've improved many of the layout helpers, we'll just inline the title tag now and not sanitize since this is commonly extracted, its much easier now for users to add that in if they want it. We added sanitized due to testing the site title with a link but we've since changed that so the site title really should just be plain text for situations like this. The link was used because often it doubled as the site title in the site header HTML but that is expected to be fully customized and branded now.
javierjulio
force-pushed
the
main-navigation
branch
from
e1d659d
to
ccba7c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the main navigation into a dedicated partial with improvements. The html head partials have now been consolidated into a single partial. The title tag is now inlined in the layout files. This revamps the dark mode styles across the board and uses a darker set of colors. The default breadcrumb links now pass
html_optionstolink_tocall so we can apply classes. The default comments resource has been updated so specific columns have a minimum width and the body is now truncated.