-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update templates and dark mode styles #8187
Commits on Dec 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 605dbad - Browse repository at this point
Copy the full SHA 605dbadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a05cf1 - Browse repository at this point
Copy the full SHA 0a05cf1View commit details -
Update comments admin resource index table
This adds some min widths and truncates the comment body.
Configuration menu - View commit details
-
Copy full SHA for ab639f9 - Browse repository at this point
Copy the full SHA ab639f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5907a17 - Browse repository at this point
Copy the full SHA 5907a17View commit details -
Update pagination styles for dark mode
We were setting default background color but its not needed since we prefer to take on the inherited background color and just apply an explicit background color on hover.
Configuration menu - View commit details
-
Copy full SHA for 2098926 - Browse repository at this point
Copy the full SHA 2098926View commit details -
Delete pagination first/last page partials
Since these are not used by the paginator we can safely delete these. Forgot to do so when combining the two original themes we had (active_admin and active_admin_countless) for a simpler, modern pagination layout.
Configuration menu - View commit details
-
Copy full SHA for 8b48005 - Browse repository at this point
Copy the full SHA 8b48005View commit details -
Refactor breadcrumbs with link_to html_options
This way we can style the default breadcrumbs from the view with Tailwind classes. If providing custom breadcrumb, since full links are given, caller should provide any classes for styling. This improves colors for light and dark modes.
Configuration menu - View commit details
-
Copy full SHA for 3986137 - Browse repository at this point
Copy the full SHA 3986137View commit details -
Still some elements to update with better dark mode styles but this gets most of the contents on the page. Updated the main navigation layout and hover/selected states. Updated the data-table and attributes-table styles, not just dark mode but spacing, borders and other styles. Imrpoved the empty-value style for all modes too.
Configuration menu - View commit details
-
Copy full SHA for 91d7e14 - Browse repository at this point
Copy the full SHA 91d7e14View commit details
Commits on Dec 28, 2023
-
Fix main navigation positioning
The content was going off screen due to h-screen usage. This was fine originally since we had the menu always be full screen vertically but we've changed that now so have to adjust the top offset based on breakpoint.
Configuration menu - View commit details
-
Copy full SHA for 3dacaa7 - Browse repository at this point
Copy the full SHA 3dacaa7View commit details -
Use add_class for default so Tailwind finds it
Otherwise these styles are purged which we don't want.
Configuration menu - View commit details
-
Copy full SHA for be7a5d5 - Browse repository at this point
Copy the full SHA be7a5d5View commit details -
Use whitespace nowrap so multi word status tags don't wrap in a table. Use pill shaped badges instead. No need to duplicate styles here since the second selector is just for updating the color based on the data attribute.
Configuration menu - View commit details
-
Copy full SHA for 9b7ddf8 - Browse repository at this point
Copy the full SHA 9b7ddf8View commit details -
Use NPM package for Tailwind plugin
This will be required for now with cssbundling-rails. Another option is to copy and paste the plugin.js file to the host app and run it and it will work. That could be an option for tailwindcss-rails users. At the moment there isn't another alternative. I've tried requiring the plugin from the gem path but it doens't seem that Tailwind can find its own modules if required that way. It has to be local.
Configuration menu - View commit details
-
Copy full SHA for c718b4c - Browse repository at this point
Copy the full SHA c718b4cView commit details -
Consolidate html head partials to one partial
Originally, we needed this as we didn't extract other views in the layout to partials. No need for specific partials now since chances are if someone wants to edit this, they will want to edit most of the HTML head anyway so easier to extract a single partial with everything already there as its not that many lines. Since we've improved many of the layout helpers, we'll just inline the title tag now and not sanitize since this is commonly extracted, its much easier now for users to add that in if they want it. We added sanitized due to testing the site title with a link but we've since changed that so the site title really should just be plain text for situations like this. The link was used because often it doubled as the site title in the site header HTML but that is expected to be fully customized and branded now.
Configuration menu - View commit details
-
Copy full SHA for ccba7c6 - Browse repository at this point
Copy the full SHA ccba7c6View commit details