Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct way to respond_to #36

Merged
merged 1 commit into from
Oct 26, 2014
Merged

Conversation

dtaniwaki
Copy link
Contributor

Hi,

It's the same as the PR in active_admin gem.
We should use respond_to_missing? instead of respond_to?.

@seanlinsley
Copy link
Contributor

Have you looked at the failing tests?

@dtaniwaki
Copy link
Contributor Author

oops. I'm sorry but I'll look into that next week.

@timoschilling
Copy link
Member

@dtaniwaki any updates?

@dtaniwaki
Copy link
Contributor Author

Sorry for the late reply. BasicObject doesn't have respond_to? method and even doesn't use respond_to_missing?. So I didn't replace the method for the one inheriting BasicObject.

timoschilling added a commit that referenced this pull request Oct 26, 2014
Use correct way to respond_to
@timoschilling timoschilling merged commit 1268e62 into activeadmin:master Oct 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants