Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please conform to XDG standard, instead of breaking it for everybody #16

Closed
eddyp opened this issue Feb 19, 2013 · 3 comments
Closed

Please conform to XDG standard, instead of breaking it for everybody #16

eddyp opened this issue Feb 19, 2013 · 3 comments
Labels
Milestone

Comments

@eddyp
Copy link
Contributor

eddyp commented Feb 19, 2013

The XDG standard says user-specific data files should be written in $XDG_DATA_HOME which defaults to $HOME/.local/share.

Appdirs explicitly breaks XDG_DATA_HOME specification and returns a path based on $XDG_CONFIG_HOME, ~/.config/appname instead of ~/.local/share/appname for user_data_dir.

This is not at all "subject to some interpretation", this is as clear as day in the XDG spec:

http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

Quote:
There is a single base directory relative to which user-specific data files should be written. This directory is defined by the environment variable $XDG_DATA_HOME

and later:

$XDG_DATA_HOME defines the base directory relative to which user specific data files should be stored. If $XDG_DATA_HOME is either not set or empty, a default equal to $HOME/.local/share should be used.

No ifs or buts. It doesn't matter at all if some apps decide not to respect the standard, a library should do the right thing, not break standards for everybody 'just because'.

To fix this, commit 362f390 should be reverted.

eddyp added a commit to eddyp/appdirs that referenced this issue Feb 20, 2013
@eddyp
Copy link
Contributor Author

eddyp commented Feb 20, 2013

The commit 74cfeb8 fixes this issue.
There is also a linux-fixes branch in my fork that also undoes the broken mangling of the case on Linux. Linux is case sensitive and messing with the case behind user's back is not a wise idea.

@eddyp eddyp mentioned this issue Feb 20, 2013
@eddyp
Copy link
Contributor Author

eddyp commented Feb 20, 2013

Fix also needs the comment correction provided by 0e398a0

@srid
Copy link
Contributor

srid commented Mar 21, 2013

merged in master.

@srid srid closed this as completed Mar 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants