Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular Dep with setuptools #87

Closed
cooperlees opened this issue Feb 22, 2017 · 3 comments
Closed

Circular Dep with setuptools #87

cooperlees opened this issue Feb 22, 2017 · 3 comments

Comments

@cooperlees
Copy link

Should appdirs support installation/building without setuptools since setuptools now depends on appdirs? Maybe falling back to distutils?

try:
from setuptools import setup
except ImportError:
from distutils.core import setup

This circular dependency is making building in my environment that checks for this much harder and hackier.

@cooperlees
Copy link
Author

Have upped the following PR:
#88

@zoofood
Copy link
Contributor

zoofood commented Feb 23, 2017

Thanks, I will get this out tonight as it sounds like it is critical.

@cooperlees
Copy link
Author

Awesome - Thanks!

Yeah, massive pain for people like us (Facebook) who build all third party modules from sdsts and have a systems that enforces deps. This circular dep blows it up. We generally do this so we can run unit tests and verify the code is legit etc. :)

@zoofood zoofood closed this as completed Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants