Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on wildcard in Cors builder's allowed_origin() #114

Merged
merged 5 commits into from Oct 10, 2020
Merged

Panic on wildcard in Cors builder's allowed_origin() #114

merged 5 commits into from Oct 10, 2020

Conversation

eupn
Copy link
Contributor

@eupn eupn commented Oct 9, 2020

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Implements #112.

Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for picking this up :)

just some initial thoughts, will sanity check running it later

actix-cors/CHANGES.md Outdated Show resolved Hide resolved
actix-cors/src/builder.rs Show resolved Hide resolved
actix-cors/src/builder.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #114 into master will increase coverage by 0.43%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   79.45%   79.89%   +0.43%     
==========================================
  Files          29       29              
  Lines        2098     2104       +6     
==========================================
+ Hits         1667     1681      +14     
+ Misses        431      423       -8     
Impacted Files Coverage Δ
actix-cors/tests/tests.rs 99.20% <66.66%> (-0.80%) ⬇️
actix-cors/src/builder.rs 82.70% <100.00%> (+0.26%) ⬆️
...headers/www_authenticate/challenge/bearer/tests.rs 100.00% <0.00%> (ø)
actix-redis/src/session.rs 81.60% <0.00%> (+0.76%) ⬆️
actix-session/src/cookie.rs 89.16% <0.00%> (+0.98%) ⬆️
actix-session/src/lib.rs 89.13% <0.00%> (+1.08%) ⬆️
actix-cors/src/inner.rs 80.90% <0.00%> (+1.81%) ⬆️
actix-cors/src/middleware.rs 72.36% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134e43a...9d00d19. Read the comment docs.

Co-authored-by: Rob Ede <robjtede@icloud.com>
@eupn eupn requested a review from robjtede October 9, 2020 13:32
@robjtede robjtede mentioned this pull request Oct 9, 2020
9 tasks
@robjtede robjtede merged commit 06f17ec into actix:master Oct 10, 2020
@robjtede robjtede linked an issue Oct 10, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide warning when using * in allow_origin
2 participants