Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error to message in test helper func #1812

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented Dec 3, 2020

PR Type

Other

PR Checklist

Check your PR fulfills the following:

  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Add error to panic

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1812 (4ede216) into master (d0c6ca7) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1812   +/-   ##
=======================================
  Coverage   53.62%   53.63%           
=======================================
  Files         133      134    +1     
  Lines       12348    12349    +1     
=======================================
+ Hits         6622     6623    +1     
  Misses       5726     5726           
Impacted Files Coverage Δ
src/test.rs 88.63% <50.00%> (ø)
actix-http/src/header/common/accept_language.rs
actix-http/src/header/common/if_match.rs
actix-http/src/header/common/if_modified_since.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/accept_charset.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/last_modified.rs 0.00% <0.00%> (ø)
actix-http/src/ws/mask.rs 2.63% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c6ca7...4ede216. Read the comment docs.

@robjtede robjtede added A-web project: actix-web B-semver-patch labels Dec 3, 2020
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JohnTitor JohnTitor merged commit b75a9b7 into actix:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants