-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove secondary particles in Geant4 simulation #2263
feat: Remove secondary particles in Geant4 simulation #2263
Conversation
Examples/Algorithms/Geant4/include/ActsExamples/Geant4/ParticleKillAction.hpp
Show resolved
Hide resolved
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
📊 Physics performance monitoring for bfa01e7Summary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #2263 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 449 449
Lines 25410 25410
Branches 11724 11724
=======================================
Hits 12521 12521
Misses 4556 4556
Partials 8333 8333 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
All our physics monitors depend on the simulation which is not directly monitored at the moment. In this PR I add a first monitoring version for Fatras and Geant4. The monitoring is not optimal yet but should be sufficient if something changes or breaks for simulation. Possible improvements: - record deltas for momenta / eta / phi and so on instead of initial and final Blocked by - #2241 - #2260 - #2262 - #2263 - #2264 - #2265 - #2266
This allows us to ignore secondary particles in the Geant4 simulation which should speed things up and remove noise when unnecessary