-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Change the MultiLayerSurfacesUpdater to use the local position and direction #3041
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3041 +/- ##
==========================================
- Coverage 49.09% 48.83% -0.27%
==========================================
Files 497 491 -6
Lines 29155 28886 -269
Branches 13851 13709 -142
==========================================
- Hits 14314 14106 -208
- Misses 4908 4954 +46
+ Partials 9933 9826 -107 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for b40eb44physmon summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me based on the really small knowledge that I have on this
Invalidated by push of fd1a18d
a0cbccf
to
62f8780
Compare
@dimitra97 there is one clang tidy failure
|
8965933
to
509b05d
Compare
…ion and direction (acts-project#3041) This PR introduces some changes in the `MultiLayerSurfacesUpdater` in order to consider the local position and direction from the navigation state and generates the path in the grid based on them. Also, since this Navigation Delegate is used in the `MultiWireStructureBuilder` I pass the transform of the multiLayer in the delegate, in order to be taken into account for the global->local transformations. (I deleted a previous branch that I have created for this and created a new one, because I had messed up with some files from main)
…ion and direction (acts-project#3041) This PR introduces some changes in the `MultiLayerSurfacesUpdater` in order to consider the local position and direction from the navigation state and generates the path in the grid based on them. Also, since this Navigation Delegate is used in the `MultiWireStructureBuilder` I pass the transform of the multiLayer in the delegate, in order to be taken into account for the global->local transformations. (I deleted a previous branch that I have created for this and created a new one, because I had messed up with some files from main)
…ion and direction (acts-project#3041) This PR introduces some changes in the `MultiLayerSurfacesUpdater` in order to consider the local position and direction from the navigation state and generates the path in the grid based on them. Also, since this Navigation Delegate is used in the `MultiWireStructureBuilder` I pass the transform of the multiLayer in the delegate, in order to be taken into account for the global->local transformations. (I deleted a previous branch that I have created for this and created a new one, because I had messed up with some files from main)
This PR introduces some changes in the
MultiLayerSurfacesUpdater
in order to consider the local position and direction from the navigation state and generates the path in the grid based on them. Also, since this Navigation Delegate is used in theMultiWireStructureBuilder
I pass the transform of the multiLayer in the delegate, in order to be taken into account for the global->local transformations.(I deleted a previous branch that I have created for this and created a new one, because I had messed up with some files from main)