-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use Core CKF extrapolation after inwards extension in Examples #3195
refactor: Use Core CKF extrapolation after inwards extension in Examples #3195
Conversation
📊: Physics performance monitoring for d992e27physmon summary
|
7078f22
to
d29ae01
Compare
…mples-track-finding-use-ckf-extrapolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do my usual ITk ttbar_pu200 test, but I don't think we have much in the way of resolution tests there.
The ITk ttbar_pu200 efficiency etc are not significantly changed by this PR. I can't speak to the resolutions. However I do see a 4.7% speedup :) It's a long time since I looked into it, but would it be a big addition to add the performance analysis plots (where we can check resolutions) to the ATLAS can test this out in Athena, so I guess it's not a top priority for us. |
I think that makes sense yeah - I am reworking the root outputting a bit which somehow ended up at the very end of my current list of tasks but generally I would like to have finder and fitter performance for the CKF instead of "CKF performance" and track summary. |
Quality Gate passedIssues Measures |
After changes in the Core
CKF
we are now able to use the extrapolated parameters from within the CKF and don't need to redo the work.Pulled out of #3188 to capture the reference change and the performance
blocked by
CKF
and pass track proxies to delegates #3161