Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Early exit for CylinderBounds::inside #3207

Merged

Conversation

andiwand
Copy link
Contributor

Move code to the left and by leveraging early return statements. Have a clear unconditional return statement at the end of the function.

Pulled out of #3170

@andiwand andiwand added this to the next milestone May 22, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label May 22, 2024
@andiwand andiwand changed the title refactor: Early exit for CylinderBounds::inside refactor: Early return for CylinderBounds::inside May 22, 2024
@andiwand andiwand changed the title refactor: Early return for CylinderBounds::inside refactor: Early exit for CylinderBounds::inside May 22, 2024
@kodiakhq kodiakhq bot merged commit 8a8e54a into acts-project:main May 23, 2024
50 checks passed
@andiwand andiwand deleted the refactor-cylinder-bounds-inside-early-exit branch May 23, 2024 09:03
kodiakhq bot pushed a commit that referenced this pull request May 23, 2024
Popped up here #3207 (comment)

I think this can be safely changed to a `double`
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 31, 2024
Move code to the left and by leveraging early return statements. Have a clear unconditional return statement at the end of the function.

Pulled out of acts-project#3170
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 31, 2024
Popped up here acts-project#3207 (comment)

I think this can be safely changed to a `double`
@andiwand andiwand modified the milestones: next, v35.1.0 Jun 1, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
Move code to the left and by leveraging early return statements. Have a clear unconditional return statement at the end of the function.

Pulled out of acts-project#3170
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
Popped up here acts-project#3207 (comment)

I think this can be safely changed to a `double`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants