-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Early exit for CylinderBounds::inside
#3207
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:refactor-cylinder-bounds-inside-early-exit
May 23, 2024
Merged
refactor: Early exit for CylinderBounds::inside
#3207
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:refactor-cylinder-bounds-inside-early-exit
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
changed the title
refactor: Early exit for
refactor: Early return for May 22, 2024
CylinderBounds::inside
CylinderBounds::inside
andiwand
changed the title
refactor: Early return for
refactor: Early exit for May 22, 2024
CylinderBounds::inside
CylinderBounds::inside
benjaminhuth
approved these changes
May 22, 2024
📊: Physics performance monitoring for 2bdfbfdphysmon summary
|
asalzburger
reviewed
May 22, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
May 23, 2024
Popped up here #3207 (comment) I think this can be safely changed to a `double`
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
Move code to the left and by leveraging early return statements. Have a clear unconditional return statement at the end of the function. Pulled out of acts-project#3170
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
Popped up here acts-project#3207 (comment) I think this can be safely changed to a `double`
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
Move code to the left and by leveraging early return statements. Have a clear unconditional return statement at the end of the function. Pulled out of acts-project#3170
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
Popped up here acts-project#3207 (comment) I think this can be safely changed to a `double`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move code to the left and by leveraging early return statements. Have a clear unconditional return statement at the end of the function.
Pulled out of #3170