-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Silence DD4HEP if requested #3263
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
=======================================
Coverage 47.65% 47.65%
=======================================
Files 507 507
Lines 29205 29205
Branches 14010 14010
=======================================
Hits 13917 13917
Misses 5264 5264
Partials 10024 10024 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea indeed with the std::cout.setstate
, I never thought of this option! Indeed its a bit hacky, but I would not be concerned about that within the examples framework.
The only thing I could think of is mult-threading issues with that, but this should run in the initialization phase and thus should not be affected.
📊: Physics performance monitoring for ba2283fphysmon summary
|
Invalidated by push of 529ee43
Oops, I didn't know that rebasing invalidates review. Should I have merged or just waited? |
@ntadej I think the GitHub button |
@andiwand No I was fine with this, just wanted to raise the thought that in principle multithreading could be an issue for such a solution, but I don't think it is in this case. |
Indeed I looked through code and I do not see any usage outside of initialisation. |
For testing purposes it is useful to disable DD4HEP logging if requested. While most of it can be disabled already some internal ROOT/DD4HEP code uses either ROOT logging or pure `std::cout`. This PR tries to silence also that. Note that `std::cout` part is a bit hacky so I'm fine if this is not merged, but maybe somebody else would be interested in this.
For testing purposes it is useful to disable DD4HEP logging if requested. While most of it can be disabled already some internal ROOT/DD4HEP code uses either ROOT logging or pure
std::cout
. This PR tries to silence also that.Note that
std::cout
part is a bit hacky so I'm fine if this is not merged, but maybe somebody else would be interested in this.