Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix try all navigators after running with track finding #3408

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

andiwand
Copy link
Contributor

After running the try all navigators with track finding a found a few bugs which lead to navigation failures. After these changes I was able to run a couple single muons without problems.

I will think about how to monitor this in the CI with a couple of events as this is nice to have for testing.

@andiwand andiwand added this to the next milestone Jul 18, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Jul 18, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

sonarcloud bot commented Jul 19, 2024

@kodiakhq kodiakhq bot merged commit 544917b into acts-project:main Jul 19, 2024
44 checks passed
@andiwand andiwand deleted the fix-tryallnavigator branch July 19, 2024 09:25
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants