Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unnecessary activeBranches.empty() condition from Core CKF #3541

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Aug 22, 2024

!result.activeBranches.empty() is guaranteed to be true with the assert above

assert(!result.activeBranches.empty() && "No active branches");

@andiwand andiwand added this to the next milestone Aug 22, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

📊: Physics performance monitoring for a966044

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review August 22, 2024 20:44
Copy link

sonarcloud bot commented Aug 24, 2024

@kodiakhq kodiakhq bot merged commit 5925819 into acts-project:main Aug 25, 2024
41 of 42 checks passed
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Aug 25, 2024
@andiwand andiwand deleted the refactor-ckf-remove-unecessary-condition branch August 25, 2024 18:01
@paulgessinger paulgessinger modified the milestones: next, v36.2.0 Aug 26, 2024
kodiakhq bot pushed a commit that referenced this pull request Aug 26, 2024
…3555)

This bug was revealed and amplified after #3541. It is possible that all branches are stopped after the filtering step which should also trigger the CKF to stop.
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 27, 2024
andiwand added a commit that referenced this pull request Aug 28, 2024
…3555)

This bug was revealed and amplified after #3541. It is possible that all branches are stopped after the filtering step which should also trigger the CKF to stop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants