Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA algorithms should handle empty inputs gracefully #414

Closed
stephenswat opened this issue Jun 7, 2023 · 2 comments · Fixed by #415
Closed

CUDA algorithms should handle empty inputs gracefully #414

stephenswat opened this issue Jun 7, 2023 · 2 comments · Fixed by #415
Assignees
Labels
bug Something isn't working cuda Changes related to CUDA

Comments

@stephenswat
Copy link
Member

Related to #413, the CUDA code currently does not check whether the inputs passed to it are empty. In some cases (e.g. in the seeding) this causes the host to request a kernel launch with zero blocks, which causes a launch failure and breaks the application. For each kernel, we should aim to determine the appropriate behaviour in case the input size is zero, so that we can handle these edge cases gracefully.

@stephenswat stephenswat added bug Something isn't working cuda Changes related to CUDA labels Jun 7, 2023
@beomki-yeo
Copy link
Contributor

I think we can simply have an if statement which checks the number of inputs

@stephenswat
Copy link
Member Author

Depending on the algorithm we will need to ensure that sane (even if empty) results are passed onto the follow-up algorithms; may not be trivial in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda Changes related to CUDA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants