-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feedback] New autocomplete #773
Comments
I expanded the scope of this issue to be the full migration to the new autocomplete component. Not just PayeeAutocomplete. Hope you don't mind. |
I actually view the "x" button more as a feature, not a bug. It's a convenient way to clear the autocomplete selection. |
The final `Autocomplete` refactors. After this is merged what's remaining is to do extensive testing and address the bugs in #773 This PR moves `Nordigen` autocomplete to the new one without using a feature flag. IMO this is a safe change given the simple nature of the Nordigen autocomplete component.
Enabling the new autocomplete for dev/preview deployments. This will allow us to spot any more issues there might be before we release the new autocomplete. #773
Could you elaborate on this one? |
Sure!
Expected behavior: undoes the deletion. Actual behavior: nothing (compare with handling of old autocomplete) |
[RESOLVED] Have another bug - request for the new autocomplete: allow the dropdown to have a min width, expanding past the input. Reason being when viewing the table on narrow screens (eg iPad) the dropdown is so small that each row wraps into 3, making it hard to scroll/select. |
@albertogasparin good idea: #834 |
Implement min-width for the autocomplete to make it look better on small screens. #773 (comment) <img width="304" alt="Screenshot 2023-03-31 at 19 02 06" src="https://user-images.githubusercontent.com/886567/229195868-7d858f18-0c1a-4a9d-95be-5dd0e4aef92c.png">
Ok, looked more into this. It's interesting.. Yes, the old autocomplete allowed global "ctrl+z" operation. But judging by this code - it was actually a bug. Since we explicitly capture undo events that happen in input boxes. I presume it's so the "undo" would apply only to the local input box and would not affect the global state. With the new autocomplete this bug is fixed. Which means we are no longer able to do global undo operation if the autocomplete field is focused. Given all this: I think this issue is a wont-fix. WDYT? |
That’s reasonable. |
@j-f1 I don't recall what was this one. Can you jog my memory?
|
Managed to reproduce it, but it also happens in the old autocomplete (see demo below). Basically it has to do with how the table virtualizes and animates the rows outside of the viewport.. When a row is moved outside of the viewport - the row (including autocomplete) is unmounted. And then re-mounted again. Which causes this flash. IMO this will be addressed once we get to the table migration. As for the autocomplete: I would put this as out-of-scope. WDYT? Screen.Recording.2023-04-01.at.19.20.31.mov |
Sure, fine with me! |
[RESOLVED] New issue: the autocomplete is a different height than regular inputs. This is mainly noticeable in the rule editor, where the condition/action rows change height when switching between e.g. |
**Actual has now been moved to a stand-alone Docker organization. If you were previously using `jlongster/actual-server` docker image - please update it to `actualbudget/actual-server`.** The release has the following notable features: - Rules can now optionally be applied when any of their conditions match (in addition to the existing option to apply when all of their conditions match) - Rules: quick-create option from the transaction table (in the “X selected” menu that shows up after selecting a transaction, choose “Create rule”) - Ability to hide decimal places for currencies with large numbers (in Settings → Formatting) - New autocomplete component (please report any bugs [here](actualbudget/actual#773)) - Lots of smaller improvements and bugfixes --------- Co-authored-by: Jed Fox <git@jedfox.com>
When adding a transaction to the transaction table, generally I will type my Payee Name E.G. Cambrian Heritage Railways there is sometimes already a Payee with that name in the list but for some reason I am presented with the following dropdown There is only one of the Payee in the list, it is an exact match, that should be selected, not sure why I am presented with the option to create the Payee with a name that distinctly already exists. I am sure it didn't used to be like this .... |
Hi, since I've updated to the April version of Actual, the new autocomplete in category select causes breaks my keyboard-centered workflow when entering a transaction. My workflow used to be following:
At this point Category is usually populated either from payee or note.
Now with the new Autocomplete component, there's a problem in Step 5: If the category is populated by Note, moving focus to the Category pre-selects Split Transaction, so hitting Tab creates a split transaction. To my knowledge, there's no way to turn a split transaction back to a regular transaction, so I need to cancel the transaction and start a new one. This issue doesn't happen when the category gets selected by Payee, so I think it has to do with delay in rule evaluation (when the category select gets focused before the category is automatically selected). I recorded the problem to better illustrate my point: Screencast.from.2023-04-12.12-41-13.webm |
You should be able to hit ctrl/cmd+Z to undo! But I agree this should be fixed. |
That was my thinking exactly. Undo works for removing an added transaction, but doesn't work for changing an uncommitted split transaction back to a regular one. |
I am having @jnv 's issue but also another similar but different one. I used to start at the bottom of my recently imported transactions and shift+tab back through the transactions until I get to the top. When I am entering a category, let's say "Food" I would previously type "Fo" and food would suggest autocomplete. At that point I should shift+tab (or tab) past it and it should fill. Instead, it removes my input and restores the category to blank. I swear it used to work "properly." Has anyone else noticed this? It works well with Enter, but not with tab anymore. |
Both of the last two reported issues also relate to |
👋 Calling off the new-autocomplete (react-select) experiment as a failure. Reverting back to previous autocomplete and fixing some things in the old one. We might sometime in the future consider other alternatives. But clearly |
The final `Autocomplete` refactors. After this is merged what's remaining is to do extensive testing and address the bugs in actualbudget#773 This PR moves `Nordigen` autocomplete to the new one without using a feature flag. IMO this is a safe change given the simple nature of the Nordigen autocomplete component.
…dget#789) Enabling the new autocomplete for dev/preview deployments. This will allow us to spot any more issues there might be before we release the new autocomplete. actualbudget#773
Implement min-width for the autocomplete to make it look better on small screens. actualbudget#773 (comment) <img width="304" alt="Screenshot 2023-03-31 at 19 02 06" src="https://user-images.githubusercontent.com/886567/229195868-7d858f18-0c1a-4a9d-95be-5dd0e4aef92c.png">
The final `Autocomplete` refactors. After this is merged what's remaining is to do extensive testing and address the bugs in actualbudget/actual#773 This PR moves `Nordigen` autocomplete to the new one without using a feature flag. IMO this is a safe change given the simple nature of the Nordigen autocomplete component.
Enabling the new autocomplete for dev/preview deployments. This will allow us to spot any more issues there might be before we release the new autocomplete. actualbudget/actual#773
Implement min-width for the autocomplete to make it look better on small screens. actualbudget/actual#773 (comment) <img width="304" alt="Screenshot 2023-03-31 at 19 02 06" src="https://user-images.githubusercontent.com/886567/229195868-7d858f18-0c1a-4a9d-95be-5dd0e4aef92c.png">
The final `Autocomplete` refactors. After this is merged what's remaining is to do extensive testing and address the bugs in actualbudget/actual#773 This PR moves `Nordigen` autocomplete to the new one without using a feature flag. IMO this is a safe change given the simple nature of the Nordigen autocomplete component.
Enabling the new autocomplete for dev/preview deployments. This will allow us to spot any more issues there might be before we release the new autocomplete. actualbudget/actual#773
Implement min-width for the autocomplete to make it look better on small screens. actualbudget/actual#773 (comment) <img width="304" alt="Screenshot 2023-03-31 at 19 02 06" src="https://user-images.githubusercontent.com/886567/229195868-7d858f18-0c1a-4a9d-95be-5dd0e4aef92c.png">
Introduced in #741.
Remaining bugs/tasks (comment below to add to the list!)
Autocomplete:
not sure the “x” button provides much value and it is super weird (it acts on mouse down + delay rather than mouse up), maybe it can be removed?When scrolling the focused row out of view it (sometimes) suddenly jumps back into view. The old component gracefully drops focus and picks it up when scrolled back into viewglobal undo/redo don’t work when focused on a text fieldPayeeAutocomplete:
GenericInput:
When the field is freeform, the suggestion menu shouldn’t appear? (maybe)Components that use the old autocomplete:
The text was updated successfully, but these errors were encountered: