Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boards.h #220

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Update boards.h #220

merged 2 commits into from
Jul 15, 2022

Conversation

ehughes
Copy link
Contributor

@ehughes ehughes commented Jun 20, 2022

Patched boot length to include IVT structure and interrupt table. Previous value would cause weird issues if program size got near the .text section length

See Bug #208

patched boot length to include IVT structure and interrupt table.  Previous value would cause weird issues if program size got near the .text section length
@tannewt tannewt requested a review from hathach June 21, 2022 20:46
@hathach
Copy link
Member

hathach commented Jul 14, 2022

sorry for late response, I am pulling out the imxrt reference manual and rt1020 to test with. Please be patient for a bit longer :).

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb !! I finally could wrap my head around this. This is indeed correct fix. Though I think we should best use all the linker symbol here to avoid the need to change this should we decide to expand the bootloader size in the future. I will try to make a update

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated to defined the BOARD_BOOT_LENGTH following the ideal suggestion in your previous comment. Which is based on the linker symbol. Tested with printf and the value is correctly 0x9000 now. Thank you very much for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants