Table align bug

[jakov]

In the example preview I found a tiny bug:

The markdown table is supposed to have the second column centered and the third column aligned right. The respective cells get a align="right" property, but they also get a style property, which effectively overwrites that:

border: 1px solid rgb(204, 204, 204); text-align: left; margin: 0px; padding: 0.5em 1em;

With text-align:left; removed from table tr th, table tr td in the "Primary Styling CSS" it works just fine.

[adam-p]

Try this: Click "Reset to Default" below the "Primary Styling CSS" box and check the table again. (Warning: If you have customized styles, save them into a text editor first.)

You can see here that the text-align:left styles has been removed:
https://github.com/adam-p/markdown-here/blob/master/src/common/default.css#L159

Let me know if this doesn't work. Otherwise, go ahead and close the issue. Thanks.

[jakov]

Oh, it seems i had an old version of the CSS. Resetting fixed it.

However, I can't remember having changed any of the CSS. Does updating update the CSS if there are no changes?

[adam-p]

Does updating update the CSS if there are no changes?

Unfortunately, it does not. The defaults get immediately saved as your preferences after you install, and they won't be automatically overwritten by new preferences. I'll make a note that it would be good if they did. (Although... if you like the old default, then you might be upset if it got changed. But hopefully that's not many people, since, hopefully, the new defaults would be better.)

If you want to see the previous version's default CSS:
https://github.com/adam-p/markdown-here/blob/v2.6.4/src/common/default.css

I'm going to close this. (Although I have a terrible feeling other people will also report it...)

[jakov]

Maybe you should just put a note in the options when they pop up after the update that one might like to update the CSS if it is not the same as the users CSS.

[adam-p]

I created a new issue for this default-CSS-reset problem: #48