Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: Use specific Nerd Font release #27

Closed
wants to merge 1 commit into from

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Feb 10, 2020

[why]
When Nerd Font evolves and new commits become pulled to master our
scripts might break.

See also warning at
https://github.com/ryanoasis/nerd-fonts#unstable-file-paths

This is the case here, because Nerd Fonts decided to rename Cascadia
when it patches it. Our subsequent renaming then failes.

[how]
Reference release v2.1.0 as this is master at the moment.
Adapt to new output file name.

[why]
When Nerd Font evolves and new commits become pulled to master our
scripts might break.

See also warning at
  https://github.com/ryanoasis/nerd-fonts#unstable-file-paths

This is the case here, because Nerd Fonts decided to rename Cascadia
when it patches it. Our subsequent renaming then failes.

[how]
Reference release v2.1.0 as this is master at the moment.
Adapt to output new file name.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@adam7
Copy link
Owner

adam7 commented Feb 11, 2020

@Finii I'm guessing #28 supersedes this and makes it unnecessary, also you should now have collaborator permissions :)

@Finii
Copy link
Collaborator Author

Finii commented Feb 11, 2020

Yes, I wanted to base #28 not on master but on the branch of this PR. To disentangle both commits as good as possible (*).
But then, of course, I could not create a branch for #27 in this repo to base #28 on it, so...

(*): Because for me #27 fixes a bug so it can/should be pulled always. But #28 is kind of a management decision, shall Delugia include more glyphs than usual Nerd Font fonts. So this is not so clear that it will be accepted by you.

Sorry for lengthy explanation :-)

Closing this because the commit is already in master.

@Finii Finii closed this Feb 11, 2020
@Finii
Copy link
Collaborator Author

Finii commented Feb 11, 2020

And btw, thank you for collaborator rights. :)

I'm not too familiar with github and tried to send you a PM asking what your intention is with the rights, but then I had to work on some other repos and fix stuff at work (where I use pure command-line git and sometimes Stash) and got sidetracked.

So with the rights I would have merged this PR (fix). But I would have left the decision to include #28 to you. I could do the manual labor, but maybe not the decisions. Maybe you want to give me some guidance of what you expect :-)

Fini

@Finii Finii deleted the bugfix/output_file_name branch February 13, 2020 05:58
@adam7
Copy link
Owner

adam7 commented Feb 18, 2020

You're welcome on collaborator rights, sorry for not being more reactive to your comments. You've repeatedly shown that you're a super helpful and dilligent contributor so I wanted to give you more freedom without me being a bottleneck.
Delugia was really just an excuse for me to experiment with github actions and an interesting problem. It turned out to be more popular than I expected and you've kept it fresh and alive and fixed issues that I completely lacked time or expertise for, thanks for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants