Make referenced Nerd Font release a parameter #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] It is easier to see similareties in the URL paths if they reference the same host. [how] Use github.com and /blob for all fonts. Signed-off-by: Fini Jastrow <Ulf.Fini.Jastrow@desy.de>
[why] The Nerd Font revision is given in a lot of places. It is better to specify data once instead of multiple times, so give it in a central place instead. [how] Use an environment variable to carry the information to all affected places (i.e. curl downloads). Signed-off-by: Fini Jastrow <Ulf.Fini.Jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
The Nerd Font revision is given in a lot of places. It is better to
specify data once instead of multiple times, so give it in a central
place instead.
[how]
Use an environment variable to carry the information to all affected
places (i.e. curl downloads).
[note]
I have no yaml setup locally, so I have to test this with the PR triggered CI.
Hopefully it will work ;->