Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript #101

Closed
theroozbeh opened this issue Feb 12, 2019 · 5 comments
Closed

Typescript #101

theroozbeh opened this issue Feb 12, 2019 · 5 comments

Comments

@theroozbeh
Copy link

Hi
Thank you for your module
Please add typescript support.

@adamgibbons
Copy link
Owner

I don't have the bandwidth but would love Typescript support as well.

@typeofweb
Copy link
Contributor

@adamgibbons would you consider accepting a PR for this?
Would you like to rewrite the source of this library in TypeScript or just add typing as index.d.ts?

@adamgibbons
Copy link
Owner

adamgibbons commented Jul 24, 2019

Both, really :-)

Adding typing in index.d.ts is definitely a win, and a much quicker win. Were we to rewrite this in TS, I think I'd want to improve the api overall, make some breaking changes, and release a 3x. E.g. two things I didn't anticipate in the beginning were that I'd eventually want to 1) parse ICS files, or 2) support more of RFC 5545.

@typeofweb
Copy link
Contributor

Me, or my team, can take care of writing index.d.ts file. We've already started, so why not share it with everyone :)

@typeofweb
Copy link
Contributor

#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants