-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove remaining usage of List::MoreUtils #205
Conversation
Rebased |
This change specifies the relatively-recent List::Util 1.33, which might not be compatible with running under Perl 5.6.x: http://matrix.cpantesters.org/?dist=Scalar-List-Utils%201.33 (I'm not at all against dropping 5.6 support, but I haven't noticed that that has happened.) |
I doubt there's any good reason to retain 5.6 support any more.
Adam
…On Fri, 30 Jun 2017 at 7:45 am, moregan ***@***.***> wrote:
This change specifies the relatively-recent List::Util 1.33, which might
not be compatible with running under Perl 5.6.x:
http://matrix.cpantesters.org/?dist=Scalar-List-Utils%201.33 (I'm not at
all against dropping 5.6 support, but I haven't noticed that that has
happened.)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#205 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHA_h4xQM8bU9vYOiqK21AiAKOIqx-Iks5sJQoAgaJpZM4NvbZM>
.
|
List::Util 1.33 is already specified as a prerequisite of PPI, there's no change there. For what it's worth, List::Util does mostly work on 5.6, just some tests fail so it has to be force installed. Dual-Life/Scalar-List-Utils#29 |
Actually List::MoreUtils requires 5.8 so this change is required for 5.6 support ;) |
@Grinnz Thanks a bunch, cherry-picked on top of master. :) |
Hah, sorry :)
Who's asking for 5.6 support? Old HPUX servers?
Adam
…On Fri, 30 Jun 2017 at 9:58 am, Dan Book ***@***.***> wrote:
Actually List::MoreUtils requires 5.8 so this change is required for 5.6
support ;)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#205 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHA_j90IcTVumJZAcsANG3-qEyaJGMSks5sJSkcgaJpZM4NvbZM>
.
|
@adamkennedy I would definitely like to get it to that place if we can make it without sacrifice. :) |
The remaining usage of List::MoreUtils can be easily replaced with any and first from List::Util. The main difference between first and firstidx is that firstidx returns -1 if the element is not found, and first returns undef, but for the majority of these instances, this case is not currently checked for anyway -- it is assumed the document is consistent with itself so the node will be found.