Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remaining usage of List::MoreUtils #205

Closed
wants to merge 1 commit into from

Conversation

Grinnz
Copy link
Contributor

@Grinnz Grinnz commented Jun 4, 2017

The remaining usage of List::MoreUtils can be easily replaced with any and first from List::Util. The main difference between first and firstidx is that firstidx returns -1 if the element is not found, and first returns undef, but for the majority of these instances, this case is not currently checked for anyway -- it is assumed the document is consistent with itself so the node will be found.

@Grinnz
Copy link
Contributor Author

Grinnz commented Jun 29, 2017

Rebased

@moregan
Copy link
Collaborator

moregan commented Jun 30, 2017

This change specifies the relatively-recent List::Util 1.33, which might not be compatible with running under Perl 5.6.x: http://matrix.cpantesters.org/?dist=Scalar-List-Utils%201.33 (I'm not at all against dropping 5.6 support, but I haven't noticed that that has happened.)

@adamkennedy
Copy link
Collaborator

adamkennedy commented Jun 30, 2017 via email

@Grinnz
Copy link
Contributor Author

Grinnz commented Jun 30, 2017

List::Util 1.33 is already specified as a prerequisite of PPI, there's no change there. For what it's worth, List::Util does mostly work on 5.6, just some tests fail so it has to be force installed. Dual-Life/Scalar-List-Utils#29

@Grinnz
Copy link
Contributor Author

Grinnz commented Jun 30, 2017

Actually List::MoreUtils requires 5.8 so this change is required for 5.6 support ;)

@wchristian
Copy link
Member

@Grinnz Thanks a bunch, cherry-picked on top of master. :)

@wchristian wchristian closed this Jul 1, 2017
@Grinnz Grinnz deleted the list_less_utils branch July 1, 2017 05:32
@adamkennedy
Copy link
Collaborator

adamkennedy commented Jul 1, 2017 via email

@wchristian
Copy link
Member

@adamkennedy I would definitely like to get it to that place if we can make it without sacrifice. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants