Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved character names #3

Closed
adamkiss opened this issue Dec 29, 2022 · 6 comments
Closed

Improved character names #3

adamkiss opened this issue Dec 29, 2022 · 6 comments

Comments

@adamkiss
Copy link
Owner

As shows, some names (places of interest sign) aren't really what people (me) might be looking for (command).

Look through original py2 workflow - https://github.com/bevesce/unicode-symbols-search - and unicode definition - https://www.unicode.org/Public/UCD/latest/ucd/NamesList.txt for alternative names, and think about how to best include them.

For the POI sign I just slapped ", command" at the end of the name, but some have multiple alternative names, and it doesn't make sense to make the subtitle 300 characters long/

@vitorgalvao
Copy link
Contributor

vitorgalvao commented Dec 29, 2022

Other suggestions:

  • (Leftwards Arrow With Hook) matching “return”. That’s how it is read by screen readers.
  • ⌃ (Up Arrowhead) matching “control” and “ctrl”.

@adamkiss
Copy link
Owner Author

@vitorgalvao yes. I'm working on a couple of improvements, and looking at merging alternative names from unicode.

I'll need to hard code the 'ctrl', but that should be the only exception.

@vitorgalvao
Copy link
Contributor

I'll need to hard code the 'ctrl', but that should be the only exception.

In that case, I’d say only “control” is enough. “ctrl” is a small convenience which isn’t worth complicating over.

@adamkiss
Copy link
Owner Author

Thinking about the arrow, there's a difference between arrow with hook and proper return symbol:

↩ - leftwards arrow with hook
⏎ - return symbol
⮐ - return left

I think I might need to add the return manually as well.

ctrl isn't a problem either, I'm mixing two unicode sources anyway :D

@vitorgalvao
Copy link
Contributor

Thinking about the arrow, there's a difference between arrow with hook and proper return symbol

Correct. I used to use the “return symbol” as well, until I passed my text through macOS’ VoiceOver. If you turn it on and select the following text:

Press ↩
Press ⏎
Press ⮐

It reads the first as “return”, the second as “return symbol”, and the last one isn’t read at all. That’s likely why the first one is the one that is transformed to an emoji.

@adamkiss
Copy link
Owner Author

That is so weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants