Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cmd.exe on Windows #100

Closed
adamralph opened this issue Jan 1, 2019 · 5 comments
Closed

Use cmd.exe on Windows #100

adamralph opened this issue Jan 1, 2019 · 5 comments
Assignees
@adamralph
Labels
breaking This change could break current consumers enhancement New feature or request
Milestone
5.0.0

Comments

@adamralph
Copy link
Owner

adamralph commented Jan 1, 2019 •
edited
Loading

As discussed.

Relates to #99

Marked as breaking, although it's speculative. It may not break anything.
@adamralph adamralph added the enhancement New feature or request label Jan 1, 2019
@adamralph adamralph self-assigned this Jan 1, 2019
@adamralph adamralph added this to the 5.0.0 milestone Jan 1, 2019
@adamralph adamralph mentioned this issue Jan 3, 2019
Merged
@adamralph adamralph mentioned this issue Jan 3, 2019
Closed
@adamralph
Copy link
Owner Author

Released in alpha 1.

@damianh
Copy link
Contributor

damianh commented Jan 3, 2019

Will give it a kick. Might have to adopt similar in LittleForker.

@adamralph
Copy link
Owner Author

@damianh did you get a chance to try this out? I wanted to send a PR to SQLStreamStore, but the yarn command doesn't run as part of the CI build, and I don't have yarn on my machine to try it, so my PR wouldn't prove anything.

@damianh
Copy link
Contributor

damianh commented Jan 20, 2019

Works locally (windows) and works in CI (linux container). Go go go

@adamralph
Copy link
Owner Author

Awesome @damianh, thanks!

@adamralph adamralph added the breaking This change could break current consumers label Feb 4, 2019
@adamralph adamralph mentioned this issue Feb 5, 2019
Merged
@thomaslevesque thomaslevesque mentioned this issue Feb 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamralph adamralph

Labels
breaking This change could break current consumers enhancement New feature or request
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@damianh @adamralph