Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development branch for v0.3.0 #118

Merged
merged 13 commits into from
Aug 21, 2013
Merged

Development branch for v0.3.0 #118

merged 13 commits into from
Aug 21, 2013

Conversation

mcollina
Copy link
Member

This should include:

Closes #113.
Closes #114.
Closes #111.
Closes #109.
Closes #124 .
Closes #28.

@mcollina mcollina mentioned this pull request Jul 20, 2013
@mcollina
Copy link
Member Author

@samirnaik, could you please verify all the changes I made to update your branch were correct? The tests pass, but another eye might spot something,

@mcollina
Copy link
Member Author

@adamvr maybe you want to include #111?

mcollina and others added 3 commits July 22, 2013 01:10
Add syntax highlighting, link examples, adjust formatting to the README.
Using the example verbatim throws "Error: Invalid message id" in the suback. Please sanity check.
Fixed borked example in Readme.
@samirnaik
Copy link
Contributor

Yep looks good. Everything with the secure server/client is running as
expected, thanks for the merge!

On Sat, Jul 20, 2013 at 4:14 PM, Matteo Collina notifications@github.comwrote:

@samirnaik https://github.com/samirnaik, could you please verify all
the changes I made to update your branch were correct? The tests pass, but
another eye might spot something,


Reply to this email directly or view it on GitHubhttps://github.com//pull/118#issuecomment-21302150
.

@adamvr
Copy link
Member

adamvr commented Jul 30, 2013

@mcollina Looks good! Feel free to pull in #111 and publish it as 0.3.0.

Connection as a Writable stream
Conflicts:
	lib/client.js
	lib/connection.js
@mcollina mcollina mentioned this pull request Aug 19, 2013
@mcollina
Copy link
Member Author

@adamvr should we produce some new docs for this version?Or we just get it out and wait for bug reports?

@mcollina mcollina merged commit 3839202 into master Aug 21, 2013
@YoDaMa YoDaMa deleted the v0.3.0-dev branch May 11, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary payloads not supported? Document and test tls client and server methods
4 participants