-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype theme editor #1499
Prototype theme editor #1499
Conversation
Also merge fs/fse imports
@letithappen your issue should be fixed now |
Looking fantastic. Can edit and preview changes using the new theme. Should this be backward compatible with old themes? Only I'm getting a notify alert using the old theme "constructorFn is not a constructor". No errors on console or terminal. |
@dancgray yeah, should definitely allow you to select un-editable themes. Will have a look at that. |
@dancgray both of your issues should now be fixed :) |
👍 All fixed, I think that the course schema will need the menu settings as well but we can add that with the menu settings changes. If I was being pedantic the saved preset item should be selected in the dropdown list on return and the preset list should be updated if one is deleted, but really it's awesome as it is :) |
Sorry @taylortom just found something else, on the second download or export of a course I get an error, terminal output Could be my install of archiver module. Will try again tomorrow. |
Superseded by #2209. |
Summary
Code for a theme editor I've developed. Could be used as a starting point for the open-source feature. Needs general tidying and tweaking to work with Learning Pool's plugins.
Summary of features:
To test
npm install
grunt build
You'll then find the old theme picker has been replaced with a new section. I've set up a test version of vanilla which exposes a load of variables -- upload this using Plugin management as usual.
Screenshots
See some screenshots below.
Theme picker
Theme settings
Colour picker component
Save preset button
Create preset modal
Manage presets modal