-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.4.0 #1740
Merged
Release 0.4.0 #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to wiki
Added Router.blockUser access which displays a Notify
This should use status codes
* Fix broken margin * Remove commented code * Convert tabs to spaces * Update sharedStyles.less * Remove extraneous bracket * Remove nesting * Remove uneven padding
Fix conflicts with refactored develop
* can/Issue-template: move contributing file to .github aswell issue template created
* can/theme-previews: updated from feedback changed icon to paintbrush default image getter used on models and 204 is now response on no preview not 404 jquery better utilised and at text localised styling brought in line with menu editor Theme preview extracted from can code and refactored
Issue template
Theme previews
* develop: browser spelling fix padding feedback updated from feedback changed icon to paintbrush Fix var name Move var declaration to avoid undefined value Fix reference to collection # Conflicts: # frontend/src/modules/editor/selectTheme/less/editorTheme.less
* can upgrades to upgrade and install script * removed version.json * fix issues caused by removing version.json fix pacakge.json version number. fix issue that stopped automatic upgrade added error catching to gitub api calls * Merge lib/application.js changes from canstudios/latest-release * Add refactored file * Refactor common code into helper file * Move framework & authoring git code into helper * Switch to use helper function Also reduce other duplication * Fix issue with framework folder path * Switch comparison to use semver * Refactor, and switch to use configuration module * Add spinner * Add delegate function to check for update data * Adjust spinner code * Make log a bit more user-friendly * Amend code style * Remove all dependencies on version.json * Remove whole framework folder before clone * Fix import errors * Remove comments * Reword message * Refactor * Start install refactor * Amend imports * Update style * Refactor * Fix broken references * Add newlines * Add temporary callback * Move config items to point of ref, as need to make use of dynamic vars * Set configResults * Refactor tenant code * Add bracket for readability * Remove line * Update tenantmanager to use local framework * Add missing import * Fix to framework install * Keep config.frameworkRevision for now * Add logs * Add error checks * Add custom directory * Fix application update check * Add missing import * Fix error handling * Update functions to use opts values * Disable logging for now * Remove framework install This is now done by tenantmanager when setting up master tenant * Add frontend build function to helpers * Update logs * Amend colouring * Hide exec logs * Add error handling * Move spinner code to helpers * Move exit code to helpers * Abstract input code * Refactor functions for more general use * Add missing bits * Update logs for readability * Fix logic * Remove extraneous code * Add helpful error for GitHub API limit error Amend some other logs for readability * Add missing error var * Update log messages * Amend to use log wrapper * Add spinner to install * Fix issue with halted install process * Fix upgrade version check issue * Allow framework version to be ‘locked’ in config.json Requires ‘framework’ attribute, can be 1, 2, or 3 figures (e.g. ‘1’, ‘1.1’ or ‘1.1.1’) * Allow undefined frameworkRevision value * Add dependency * Set env var to silence install output * Remove adapt_framework folder from .gitignore * Amend in-line with review by @tomgreenfield * Remove unused functions * Refactor * Fix error handling * Fix typos * Add config.json install overrides Also refactor input configs * Switch to use writeJSON * Add input validators/transforms * Refactor for readability * Fix error bug * Fix error check * Remove .env file generation as we don’t support foreman * Update prompt dev to allow password replace * Remove .env and .vagrant * Fix config output * Update feedback texts * Remove reference to version.json * Fix issue with framework install directory * Removed unused lines * Move into single applyEachSeries * Don’t modify existing object * Pass opts to bowermanager * Fix issue with framework plugin isntall * Refactor code * Change prompt.delimiter to match install script * Fix issue with undefined masterTenantID * Make SMTP input optional * Remove redundant code * Tidy output logs * Move init * Stop newline after passwords * Move installHelpers * Move further up * Uncouple function from framework lock * Move input code to installHelpers * Update instructional text * Refactor error handling code * Fix issue with authoring update erroring on git fetch * Move log * Rewrite for readability * Make revision input optional But must specify one… * Refactor for error handling * Fix framework update Now updateRepos always does a fetch Resets to remote/branch * Fix updateRepo to allow any valid revision * Remove logs * Remove node_modules before installing deps * Amend user instruction text * Fix typo * Use backticks * Amend logging * Update log * Fix issue with returning error after exec * Default framework URL to adaptlearning * Return error if trying to upgrade with custom repos * Refactor error handling code * Split up server config items to let us dynamically set rootUrl.default * Remove unused function * Switch processes to use remote name ‘origin’ * Fix config defaults * Return data with callback * Switch spinner library due to issue on windows * Fix broken var reference * Update log for usability * Allow for config.json value * Fix whitespace * Remove log from config.json install * Add db connection check * Move out of async.race due to execution time * Reduce animation framerate * Fix error handler
* Add release notes * Fix formatting * Update date * Update titles * Reword opening paragraph * Remove INSTALL.md content * Add further changes
Was called infinitely if value wasn’t undefined
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.