Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.11.2 #2705

Merged
merged 30 commits into from
Sep 25, 2023
Merged

Release v0.11.2 #2705

merged 30 commits into from
Sep 25, 2023

Conversation

snyk-bot and others added 19 commits October 28, 2022 08:23
#### Fixing domainsEnabled issue in Adapt Authoring
If you are getting following error in console
```
(node:23152) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead. (Triggered by calling processImmediate on process.)
(Use `node --trace-deprecation ...` to show where the warning was created)
```
Then follow the steps mentioned below:
Steps:
1. Application.js
	1. Modify connection options with domainsEnabled for connect-mongodb-session
	2. Instead of requestDomain.enter use requestDomain.run(next) and comment next()
2. permissions.js inside policyChecker function
	1. Line 497, update to
		1. const user = app.usermanager.getCurrentUser() || JSON.parse(JSON.stringify(req.session.passport.user));
3. Manually install
	1. npm i connect-mongodb-session@2.4.1
	2. npm i mongoose@5.8.13
@taylortom taylortom marked this pull request as draft May 19, 2023 15:15
@taylortom taylortom added this to the v0.11.2 milestone May 19, 2023
@simondate simondate marked this pull request as ready for review June 13, 2023 10:17
@simondate simondate marked this pull request as draft June 13, 2023 10:18
@taylortom taylortom marked this pull request as ready for review August 14, 2023 16:45
@simondate simondate self-requested a review August 15, 2023 09:31
Copy link
Member

@simondate simondate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pages aren't loading and getting 500 errors from any API call.

Most likely an issue caused by either the bump of the Node version or the mongodb major version.

Copy link
Member

@simondate simondate Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting 500 errors from any request made. Throws a Error: Failed to determine user's tenant! in the console whenever this happens.

I imagine this is caused by the upgrade of mongodb from 3.7.3 to 4.10.0.

I'm testing now reverting these changes.

Copy link
Member

@simondate simondate Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just google searched the error message and found this forum thread from 3 years ago https://community.adaptlearning.org/mod/forum/discuss.php?d=3811

I can confirm that the issue gets fixed if you run npm install mongoose@5.8.13 . This version of mongoose was specified in the package.json file so I'm not sure why it wasn't working in the first place. Any ideas @taylortom ?

simondate
simondate previously approved these changes Aug 15, 2023
Copy link
Member

@simondate simondate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested with a clean install with the new package-lock.json file. The couldn't find tennant issue is no longer replicable.

All other issues are still fixed. I've tested #2697 and #2696 and haven't been able to replicate either.

@taylortom
Copy link
Member Author

Currently running a production test, will let you know if we see any issues

@taylortom taylortom changed the title Release/0.11.2 Release v0.11.2 Aug 21, 2023
@@ -13,29 +13,29 @@
},
"main": "index",
"engines": {
"node": "12 || 14"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using node versions higher than 18.15.0 will cause installation of certain plugins to fail, due to ZJONSSON/node-unzipper#271. (after uploading and unzipping, properties.schema will be mangled, causing JSON.parse to fail).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added your comment as an issue (#2735) for discussion with the dev team :)

@taylortom
Copy link
Member Author

This has been tested in a production environment, with no new issues reported.

@taylortom taylortom merged commit e0952e0 into master Sep 25, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants