issue/2884 Automatic detection of view-only question models (#2885)

adaptlearning · Aug 24, 2020 · 90dc249 · 90dc249
1 parent 021daed
commit 90dc249
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/core/js/adapt.js b/src/core/js/adapt.js
@@ -270,6 +270,14 @@ define([
         nameModelOrData = nameModelOrData.toJSON();
       }
       if (nameModelOrData instanceof Object) {
+        const name = nameModelOrData._component;
+        const entry = this.store[name];
+        const isViewOnlyQuestion = entry && !entry.model && entry.view && entry.view._isQuestionType;
+        if (isViewOnlyQuestion) {
+          // Use question model by default
+          this.log && this.log.deprecated(`Assuming a question model for a view-only question: ${name}`);
+          return 'question';
+        }
         const names = [
           typeof nameModelOrData._model === 'string' && nameModelOrData._model,
           typeof nameModelOrData._component === 'string' && nameModelOrData._component,

diff --git a/src/core/js/models/questionModel.js b/src/core/js/models/questionModel.js
@@ -335,6 +335,9 @@ define([
 
   }
 
+  // This abstract model needs to registered to support deprecated view-only questions
+  Adapt.register('question', { model: QuestionModel });
+
   return QuestionModel;
 
 });