Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: router's navigateToHomeRoute function causes the page to scroll to the top #1079

Closed
moloko opened this issue May 26, 2016 · 0 comments
Closed

core: router's navigateToHomeRoute function causes the page to scroll to the top #1079

moloko opened this issue May 26, 2016 · 0 comments
Assignees
@moloko

Comments

@moloko
Copy link
Contributor

moloko commented May 26, 2016

...prior to navigating back to the home route

This is particularly noticeable if you're using an extension like pageIncompletePrompt or keepScrollPosition - it stops the latter from working since the window.scrollY will always be 0 if you've used the back button
@moloko moloko self-assigned this May 26, 2016
moloko added a commit that referenced this issue May 26, 2016
@moloko
set navigateToHomeRoute to navigate to '#/' (instead of '#') to stop …
ab20624 
…the page from scrolling to the top immediately prior to navigation (see #1079)
@moloko moloko mentioned this issue May 26, 2016
Merged
himanshu1618 pushed a commit that referenced this issue May 28, 2016
Merge pull request #1080 from adaptlearning/issue/#1079
27c814a 
set navigateToHomeRoute to navigate to '#/' (instead of '#') to stop …
@moloko moloko closed this as completed Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moloko