Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review all the core .schema files #1435

Closed
moloko opened this issue Feb 23, 2017 · 3 comments
Closed

review all the core .schema files #1435

moloko opened this issue Feb 23, 2017 · 3 comments
Assignees
Labels

Comments

@moloko
Copy link
Contributor

moloko commented Feb 23, 2017

There's a few entries in course.model.schema that don't look to be used any more and I'm sure there will be others.

Similarly there's some properties that are missing (e.g. _isVisible) and some discrepancies between the versions in the framework and those in the AT - for example contentobject.model.schema has pageBody in the framework version but not in the authoring tool version.

@moloko moloko added the task label Feb 23, 2017
@moloko
Copy link
Contributor Author

moloko commented Feb 23, 2017

Ones we've found so far that don't seem to be needed any more:

  • _ariaLabels.menu
  • _ariaLabels.menuItem
  • _ariaLabels.menuViewButton
  • _ariaLabels.navigationBack
  • _ariaLabels.closeResources
  • _ariaLabels.drawerBack (_ariaLabels.previous is what's currently assigned to the Drawer's back button in drawer.hbs)
  • _ariaLabels.menuBack

@moloko moloko changed the title check for unused values in course.model.schema review all the core .schema files Aug 10, 2017
@moloko moloko self-assigned this Aug 10, 2017
@moloko
Copy link
Contributor Author

moloko commented Aug 14, 2017

instruction seems to be missing for both article and block - it's referenced in article.hbs and block.hbs but not in the .schema files

@moloko
Copy link
Contributor Author

moloko commented Sep 26, 2017

AT develop branch has had _onScreen added to contentObject/article/block/component schemas, need to add this to the framework's files

tomgreenfield added a commit that referenced this issue Oct 4, 2017
update to include the new _onScreen settings
@moloko moloko closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant