Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom class to notify #1957

Closed
lc-thomasberger opened this issue Feb 6, 2018 · 2 comments
Closed

add custom class to notify #1957

lc-thomasberger opened this issue Feb 6, 2018 · 2 comments
Assignees
Milestone

Comments

@lc-thomasberger
Copy link
Member

Notify should accept custom classes

Since Notify accepts now a custom view, it will need better styling support. For instance HotGraphic will need to reset the background-color of the popup. This will only work if a class can be set at the top level of Notify.

            Adapt.trigger("notify:popup", {
                _view: new HotgraphicPopupView({
                    model: this.model
                }),
                _isCancellable: false,
                _classes: ' hotgraphic' // will be added tho notfiyView.$el
            });
@lc-thomasberger
Copy link
Member Author

_isCancellable hides the close button and also disables close by clicking on the backdrop.
I think it would be good to have more fine grained options here:
_showCloseButton
_closeOnBackdrop

_isCancellable would set both values for backwards compatibility.

@oliverfoster
Copy link
Member

could you split _isCancellable out before we document the subview stuff? @lc-thomasberger
now is the time to do that.

@moloko moloko changed the title add custom class to notfiy add custom class to notify Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants