Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt_framework: babel fast-async causes very slow compilation #2816

Closed
oliverfoster opened this issue Jun 29, 2020 · 2 comments
Closed

adapt_framework: babel fast-async causes very slow compilation #2816

oliverfoster opened this issue Jun 29, 2020 · 2 comments
Assignees
Labels

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jun 29, 2020

Subject of the issue

I introduced fast-async to help debugging promises but it seems to elongate the build process by about 6 seconds, which is not ideal.

Debugging promises is slightly more painful without fast-async, as the call-stack is a bit longer and the errors aren't as clear, but it beats having to wait a minimum of 6 seconds a time for each compilation cycle.

Since I segregated the babel task into a compile and a dev version, debugging promises seems to have improved without needing fast-async.

Suggest removal.

@moloko
Copy link
Contributor

moloko commented Jun 29, 2020

worth adding a switch for enabling this when needed?

@oliverfoster
Copy link
Member Author

oliverfoster commented Jun 29, 2020

Nah, I've done some more reading into the library and I'm convinced it's not a great idea to keep it as a dependency. The owner has expressed a strong unwillingness to maintain it on the babel forums despite it being a recommended package in the babel docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants