Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default FW -> AT import issues - PLP settings #2841

Closed
simondate opened this issue Jul 23, 2020 · 10 comments
Closed

default FW -> AT import issues - PLP settings #2841

simondate opened this issue Jul 23, 2020 · 10 comments
Labels

Comments

@simondate
Copy link
Member

simondate commented Jul 23, 2020

Subject of the issue/enhancement/features

When you create the framework using adapt create course the JSON for Page Level Progress isn't complete and breaks what should be a direct import into the Authoring Tool.

I propose updating the JSON so that a direct import is possible.

This could also be fixed by changing the PLP extension code to be more defensive (accommodating of incomplete JSON).

Your environment

  • version (Framework) v5.6.1

Steps to reproduce

Tell us how to reproduce this issue.

  1. create a course using adapt create course
  2. Import the course into the Authoring Tool
  3. Try to run the course
@moloko
Copy link
Contributor

moloko commented Jul 23, 2020

This could also be fixed by changing the PLP extension code to be more defensive (accommodating of incomplete JSON).

I agree and I think we should do this as well

@olivermartinfoster
Copy link
Contributor

Could we just do the PLP defensive code and not remove the indicators from the default course?

@moloko moloko mentioned this issue Jul 23, 2020
@moloko
Copy link
Contributor

moloko commented Jul 23, 2020

Could we just do the PLP defensive code and not remove the indicators from the default course?

We should definitely do the defensive code but @simondate has not actually removed the indicators from the default course

@simondate
Copy link
Member Author

As Matt said I made the JSON reflect what is currently in the pre-installed course.

I've never used this PLP functionality myself. I like having it half on and half off to show that there is a choice.

@oliverfoster
Copy link
Member

oliverfoster commented Jul 24, 2020

Sweet, I misunderstood then. Ta 👍

@oliverfoster
Copy link
Member

do the defensive code bit

@oliverfoster oliverfoster reopened this Jul 30, 2020
@oliverfoster
Copy link
Member

oliverfoster commented Jul 30, 2020

@simondate what was the original error / problem / point of failure? can I have the console log or similar?

@simondate
Copy link
Member Author

The course wouldn't run when you imported it. There was an error in the developer console that mentioned _isCompletionIndicatorEnabled

@oliverfoster
Copy link
Member

As you can see from this search https://github.com/adaptlearning/adapt-contrib-pageLevelProgress/search?q=_isCompletionIndicatorEnabled&unscoped_q=_isCompletionIndicatorEnabled

https://github.com/adaptlearning/adapt-contrib-pageLevelProgress/blob/master/js/adapt-contrib-pageLevelProgress.js#L76 This is the only place _isCompletionIndicatorEnabled is referenced which would never cause and error. I cannot proceed without more info.

@simondate
Copy link
Member Author

explorer_0rgrL1kXW2

chrome_cil1nAXnJi

chrome_23JrjZmjF5

chrome_QPCa9ABEpQ

Menu loads but error shows

chrome_6ZymSp1A67

Any page with a component with the missing attribute doesn't load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants