Changes required by adapt_authoring project #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - new 'grunt server-build' task, which allows building the framework in preparation for adding in the actual course JSON at a later time - two new switch options: --theme - used to specify an Adapt theme --outputdir - used to specify a directory where the /build folder will be created, this is used in outputting to different folders, what would be different framework 'builds'
This was causing build failures in Travis.
|
+1 |
|
I'm pretty sure Did you want to get the last character? if so Also should Apart from that it looks ok. |
Corrected per the comments from @cajones.
This is to allow 'grunt build' to run successfully when the 'production' switch is used with npm install.
|
|
||
| if (outputdir) { | ||
| if (outputdir.substring(outputdir.length - 1, outputdir.length) !== '/') { |
There was a problem hiding this comment.
don't need the second argument to substring here
|
+1 |
1 similar comment
|
+1 |
brian-learningpool
added a commit
that referenced
this pull request
Jul 30, 2014
Changes required by adapt_authoring project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights are:
These settings will have no impact on existing grunt tasks.