Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement batch fitting #16

Closed
adareau opened this issue May 7, 2021 · 4 comments
Closed

Implement batch fitting #16

adareau opened this issue May 7, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers next This is our next step

Comments

@adareau
Copy link
Owner

adareau commented May 7, 2021

When several runs are selected, clicking on "FIT" should trigger a batch fitting

@adareau adareau added enhancement New feature or request good first issue Good for newcomers fitting labels May 7, 2021
@adareau
Copy link
Owner Author

adareau commented May 12, 2021

Note: there is now a progress bar in the gui, that could be used to monitor the progress of the batch fitting 😃

@quentinmarolleau
Copy link
Collaborator

quentinmarolleau commented Jun 3, 2021

I do not understand the point of the the fitBrowserButton: it seems to be a duplication of the fitButton, and they call the same GUI function.

I suggest to keep it simple and remove it.

image

@adareau
Copy link
Owner Author

adareau commented Jun 4, 2021

The point is that the fit button from the fit panel fitButton is sometimes hidden, whereas the other one is always visible. Also, sometimes you fit after selecting files on the browser, and sometimes after changing fit settings from the fit panel, hence the duplicate.

In the end, there is also a keyboard shortcut "CTRL+F", so I guess this is no big deal if you remove one button.

I would suggest that you leave the button when working on this issue, to avoid interferences. Maybe during the "freeze" of devel, when working on the first 'beta' version, we will have a discussion on the gui layout in parallel with the code cleaning.

@adareau adareau added next This is our next step and removed fitting labels Jun 17, 2021
@adareau
Copy link
Owner Author

adareau commented Jun 28, 2021

implemented in #88

@adareau adareau closed this as completed Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers next This is our next step
Projects
None yet
Development

No branches or pull requests

2 participants