Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canceling an edit action for a task item saves any changes made to task header and description #13

Closed
Adastros opened this issue Nov 8, 2022 · 0 comments
Closed

Canceling an edit action for a task item saves any changes made to task header and description #13

Adastros opened this issue Nov 8, 2022 · 0 comments
Assignees
@Adastros
Labels
bug Something isn't working

Comments

@Adastros
Copy link
Owner

Adastros commented Nov 8, 2022

Canceling an edit action for a task item should discard any changes made to task header and description.
@Adastros Adastros added the bug Something isn't working label Nov 8, 2022
@Adastros Adastros self-assigned this Nov 8, 2022
Adastros added a commit that referenced this issue Nov 12, 2022
@Adastros
Fix bug where canceling task edit saves changes
c28cc82 
Fixes #13

The cancelTaskEditListener and AddEditButtonListener methods in taskController.js
were updated to use data- attributes to store the previous task header and
description data. On canceling an edit action, the task header and description
data would be pulled from the data- attributes.

Previously, canceling an edit action would cause taskController to pull
the task header and description data from the taskForm the user interacted
with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adastros Adastros

Labels
bug Something isn't working
Projects
Todo List Project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Adastros