Skip to content

Commit

Permalink
Remove flow (#1298)
Browse files Browse the repository at this point in the history
  • Loading branch information
amanmahajan7 committed Oct 16, 2018
1 parent 67db0d2 commit a0b6801
Show file tree
Hide file tree
Showing 16 changed files with 24 additions and 209 deletions.
1 change: 0 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@ bower.json
CONTRIBUTING.md
.flowconfig
secure-file
flow
ci
npm-debug.log
6 changes: 0 additions & 6 deletions flow/.flowconfig

This file was deleted.

3 changes: 0 additions & 3 deletions flow/examples/.flowconfig

This file was deleted.

Binary file removed flow/flow.exe
Binary file not shown.
7 changes: 0 additions & 7 deletions flow/libs/CellCopyPasteEvent.js

This file was deleted.

6 changes: 0 additions & 6 deletions flow/libs/CellDragEvent.js

This file was deleted.

5 changes: 0 additions & 5 deletions flow/libs/Editor.js

This file was deleted.

151 changes: 0 additions & 151 deletions flow/libs/SyntheticKeyboardEvent.js

This file was deleted.

2 changes: 1 addition & 1 deletion packages/common/cells/headerCells/SortableHeaderCell.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class SortableHeaderCell extends React.Component {
return this.props.sortDirection === 'NONE' ? '' : String.fromCharCode(unicodeKeys[this.props.sortDirection]);
};

render(): ?ReactElement {
render() {
let className = joinClasses({
'react-grid-HeaderCell-sortable': true,
'react-grid-HeaderCell-sortable--ascending': this.props.sortDirection === 'ASC',
Expand Down
1 change: 0 additions & 1 deletion packages/react-data-grid-addons/src/formatters/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* @flow */
// not including this
// it currently requires the whole of moment, which we dont want to take as a dependency
const ImageFormatter = require('./ImageFormatter');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ class ApiReference extends React.Component {
</div>
<div className="code-block flow">
<pre>
/* @flow */
<br />
<code>{GridRowsUpdateEvent}</code>
</pre>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ class Example extends React.Component {
stateCopy.columns.splice(columnSourceIndex, 1)[0]
);

const emptyColumns = Object.assign({},this.state, { columns: [] });
const emptyColumns = Object.assign({}, this.state, { columns: [] });
this.setState(
emptyColumns
);

const reorderedColumns = Object.assign({},this.state, { columns: stateCopy.columns });
const reorderedColumns = Object.assign({}, this.state, { columns: stateCopy.columns });
this.setState(
reorderedColumns
);
Expand Down Expand Up @@ -75,7 +75,7 @@ class Example extends React.Component {

render() {
return (
<DraggableContainer
<DraggableContainer
onHeaderDrop={this.onHeaderDrop}>
<ReactDataGrid
columns={this.state.columns}
Expand Down
10 changes: 5 additions & 5 deletions packages/react-data-grid/src/Draggable.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ class Draggable extends React.Component {
onDrag: () => {}
};

state: {drag: ?any} = {
state = {
drag: null
};

componentWillUnmount() {
this.cleanUp();
}

onMouseDown = (e: SyntheticMouseEvent) => {
onMouseDown = (e) => {
let drag = this.props.onDragStart(e);
if (e.preventDefault) {
e.preventDefault();
Expand All @@ -47,7 +47,7 @@ class Draggable extends React.Component {
this.setState({drag});
};

onMouseMove = (e: SyntheticEvent) => {
onMouseMove = (e) => {
if (this.state.drag === null) {
return;
}
Expand All @@ -59,7 +59,7 @@ class Draggable extends React.Component {
this.props.onDrag(e);
};

onMouseUp = (e: SyntheticEvent) => {
onMouseUp = (e) => {
this.cleanUp();
this.props.onDragEnd(e, this.state.drag);
this.setState({drag: null});
Expand All @@ -76,7 +76,7 @@ class Draggable extends React.Component {
return createObjectWithProperties(this.props, knownDivPropertyKeys);
};

render(): ?ReactElement {
render() {
return (
<div {...this.getKnownDivProps()}
onMouseDown={this.onMouseDown}
Expand Down
20 changes: 10 additions & 10 deletions packages/react-data-grid/src/HeaderCell.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require('../../../themes/react-data-grid-header.css');

import PropTypes from 'prop-types';

function simpleCellRenderer(objArgs: {column: {name: string}}): ReactElement {
function simpleCellRenderer(objArgs) {
let headerText = objArgs.column.rowType === 'header' ? objArgs.column.name : '';
return <div className="widget-HeaderCell__value">{headerText}</div>;
}
Expand All @@ -27,15 +27,15 @@ class HeaderCell extends React.Component {
renderer: simpleCellRenderer
};

state: {resizing: boolean} = {resizing: false};
state = {resizing: false};

onDragStart = (e: SyntheticMouseEvent) => {
onDragStart = (e) => {
this.setState({resizing: true});
// need to set dummy data for FF
if (e && e.dataTransfer && e.dataTransfer.setData) e.dataTransfer.setData('text/plain', 'dummy');
};

onDrag = (e: SyntheticMouseEvent) => {
onDrag = (e) => {
let resize = this.props.onResize || null; // for flows sake, doesnt recognise a null check direct
if (resize) {
let width = this.getWidthFromMouseEvent(e);
Expand All @@ -45,19 +45,19 @@ class HeaderCell extends React.Component {
}
};

onDragEnd = (e: SyntheticMouseEvent) => {
onDragEnd = (e) => {
let width = this.getWidthFromMouseEvent(e);
this.props.onResizeEnd(this.props.column, width);
this.setState({resizing: false});
};

getWidthFromMouseEvent = (e: SyntheticMouseEvent): number => {
getWidthFromMouseEvent = (e) => {
let right = e.pageX || (e.touches && e.touches[0] && e.touches[0].pageX) || (e.changedTouches && e.changedTouches[e.changedTouches.length - 1].pageX);
let left = ReactDOM.findDOMNode(this).getBoundingClientRect().left;
return right - left;
};

getCell = ()=> {
getCell = () => {
const {height, column, renderer} = this.props;
if (React.isValidElement(renderer)) {
// if it is a string, it's an HTML element, and column is not a valid property, so only pass height
Expand All @@ -69,7 +69,7 @@ class HeaderCell extends React.Component {
return this.props.renderer({column});
};

getStyle = (): {width:number; left: number; display: string; position: string; overflow: string; height: number; margin: number; textOverflow: string; whiteSpace: string } => {
getStyle = () => {
return {
width: this.props.column.width,
left: this.props.column.left,
Expand All @@ -82,7 +82,7 @@ class HeaderCell extends React.Component {
};
};

setScrollLeft = (scrollLeft: number) => {
setScrollLeft = (scrollLeft) => {
let node = ReactDOM.findDOMNode(this);
node.style.webkitTransform = `translate3d(${scrollLeft}px, 0px, 0px)`;
node.style.transform = `translate3d(${scrollLeft}px, 0px, 0px)`;
Expand All @@ -97,7 +97,7 @@ class HeaderCell extends React.Component {
}
};

render(): ?ReactElement {
render() {
let resizeHandle;
if (this.props.column.resizable) {
resizeHandle = (<ResizeHandle
Expand Down
Loading

0 comments on commit a0b6801

Please sign in to comment.