-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't freeze checkbox / selection column #1386
Comments
Are you using an old version? I have no idea how you got it to not freeze that column since you can see in the code I pointed to that its definitely freezing them. It also appears in the demo: If you shrink the screen enough to get the columns that way. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions. |
This is only stale because I haven't received a response yet. This issue still exists. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions. |
This still hasn't been addressed |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions. |
I don't think this is stale. We haven't heard from the maintainers on it but its definitely still a problem that is causing me and my customers pain =) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions. |
I wish the stale bot would stop closing good tickets |
Issue still exists. Keep open |
Shouldn't it be buggy because of the ReactJS version in use? I'm having the same issue and my project is using v16.8.6. I'm looking for a solution as well, and maybe there's not enough support in current releases with 16.x ReactJS features (?). Should take a look in the frozen cells rendering/updating behavior. |
The same concern here on mobile. A way to adjust to checkbox column width will also be helpful. Besides, the delayed rendering is really not the most appealing |
After investigating the stuttering behavior of frozen columns, I found out that it has something to do with trackpads' inertial scrolling which is the decelerating part of page scrolling after you lift fingers off the trackpad. And scroll/mousewheel events still fire during it. Therefore in Viewport.tsx,
isScrolling is updated with a delay with some debouncing on top of it.
Such pattern appears to also cause table headers' horizontal moves more slowly compared to that of table body.
I have been stuck on this and any help will be appreciated. |
I solved it using CSS. I targeted the following cells to stop the transform property which make this user delay experiance:
PS: the header check box cells is separate than the row body. |
You just made the frozen columns always stay at the left of the viewport but they need to move as users scroll so the columns appear to be frozen. Do you mind showing a demo if it is actually working for you? |
Hi, i have the same issue, any update ? |
Same issue here. Would like a response. |
This can be achieved in v7 canary https://github.com/adazzle/react-data-grid/blob/canary/CHANGELOG.md you should be able to do
|
Have you already searched for similar issues? Please help us out and double-check first!
Yes, I've also looked at the code.
Also, please don't be that person who deletes this template. It's here for a reason.
Thanks!
Which version of React JS are you using?
✅ Officially supported ✅
☣️ Not officially supported, expect warnings and errors ☣️
Which browser are you using?
✅ Officially supported ✅
I'm submitting a ...
Issue Details
I'm trying to use the
rowSelection
property to add a checkbox column onto my table. But it is settingfrozen: true
which is unexpected behavior. I don't want, need, or like the frozen behavior. It means when my table is on mobile the space is used up by the checkbox so they view less data. The setting seems to be here:react-data-grid/packages/react-data-grid/src/ReactDataGrid.js
Line 632 in faa8811
Can you at least offer an option like
rowSelection { freeze: false }
?The text was updated successfully, but these errors were encountered: