RDG Tree Cell Expand Styling Issues. #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesPortelli
requested review from
amanmahajan7 and
malonecj
and removed request for
amanmahajan7
|
Can you catchup master, we just synced next and master |
|
Done @amanmahajan7 |
malonecj
approved these changes
Oct 29, 2018
amanmahajan7
requested changes
Oct 29, 2018
| if (this.canExpand()) { | ||
| cellExpander = <CellExpand expandableOptions={this.props.expandableOptions} onCellExpand={this.onCellExpand} />; | ||
| } | ||
|
|
There was a problem hiding this comment.
const cellExpander = this.canExpand() && (
<CellExpand expandableOptions={this.props.expandableOptions} onCellExpand={this.onCellExpand} />`
);
packages/react-data-grid/src/Cell.js
Outdated
| return ( | ||
| <div className="react-grid-Cell__value"> | ||
| {cellDeleter} | ||
| <div style={{ marginLeft: marginLeft, position: 'relative', top: '50%', transform: 'translateY(-50%)' }}> |
There was a problem hiding this comment.
Shorthand property names can be used
<div style={{ marginLeft, position: 'relative', top: '50%', transform: 'translateY(-50%)' }}>
| }; | ||
| }; |
| @@ -1,68 +1,60 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Can we rename the test file to CellExpander.spec.js to match the component file
| expect(testElement.find('span.rdg-cell-expand').text()).toBe(CellExpand.DOWN_TRIANGLE); | ||
| const { wrapper } = setup({ expanded: true }); | ||
|
|
||
| expect(wrapper.state('expanded')).toBeTruthy(); |
There was a problem hiding this comment.
Rather than setting the state, can we use simulate to mimic users behavior
wrapper.simulate('click'); // Not sure if this will work but the idea is to simulate a click event
expect(wrapper.find('span').text()).toBe(CellExpand.DOWN_TRIANGLE);
| expect(testElement.find('span.rdg-cell-expand').text()).toBe(CellExpand.RIGHT_TRIANGLE); | ||
| const { wrapper } = setup({ expanded: false }); | ||
|
|
||
| expect(wrapper.state('expanded')).toBeFalsy(); |
There was a problem hiding this comment.
We should not test state, that is an implementation detail. If expanded variable name is changed then the tests should not break
| wrapper.find('span').simulate('click'); | ||
| expect(wrapper.state('expanded')).toBeTruthy(); | ||
| wrapper.find('span').simulate('click'); | ||
| expect(wrapper.state('expanded')).toBeFalsy(); |
There was a problem hiding this comment.
I think we can delete some of these tests and just check the span's text after the click event
added 2 commits
October 29, 2018 18:00
amanmahajan7
approved these changes
Oct 31, 2018
malonecj
pushed a commit
that referenced
this pull request
Nov 15, 2018
* Fix cell actions exmaple. * Fix styling issues for cell expansion and childrow indents. * fix minor styling issue * fix test * remove f describe * address comments * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify styling so that Tree view with rows larger than 35px will be styled correctly.
Modify code and styles so that the Cell Exapnder will not be overlapped by the cell content.