Use aria-selected to style selected cell/rows #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
changed the title
nstepien
requested changes
May 4, 2021
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
nstepien
previously approved these changes
May 4, 2021
|
Found a bug with this approach 😎 |
nstepien
requested changes
May 4, 2021
nstepien
approved these changes
May 4, 2021
gernotkogler
pushed a commit
to Garaio-REM/react-data-grid
that referenced
this pull request
May 13, 2021
* Add aria-selected styles * Fix test * Use aria-selected for group rows * Fix tests * Fix types * Fix typo * Update src/style/grouprow.ts Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Fix aria-selected on the group row Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reach UI also uses a similar strategy and it makes sense IMO as it forces us to design accessible components.