Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize onRowsChange: only update changed rows #2390

Merged
merged 2 commits into from
May 6, 2021

Conversation

amanmahajan7
Copy link
Contributor

No description provided.

@amanmahajan7 amanmahajan7 self-assigned this May 6, 2021
@amanmahajan7 amanmahajan7 changed the title Remove unchanged rows before calling onRowsChange Optimize onRowsChange: only update changed rows May 6, 2021
@amanmahajan7 amanmahajan7 requested a review from nstepien May 6, 2021 16:51
nstepien
nstepien previously approved these changes May 6, 2021
src/DataGrid.tsx Show resolved Hide resolved
Copy link
Contributor

@nstepien nstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@amanmahajan7 amanmahajan7 merged commit 74e1b28 into canary May 6, 2021
@amanmahajan7 amanmahajan7 deleted the am-check-row-change2 branch May 6, 2021 17:09
gernotkogler pushed a commit to Garaio-REM/react-data-grid that referenced this pull request May 13, 2021
* Filter unchanged rows

* Handle handleDragEnd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants