Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zone tags #2

Closed
next-sentence opened this issue Feb 22, 2017 · 1 comment
Closed

zone tags #2

next-sentence opened this issue Feb 22, 2017 · 1 comment

Comments

@next-sentence
Copy link

When I retrieve zone tag I get the same result as in doc

AdButler\ZoneTag JSON: {
  "object": "zone_tag",
  "url": "/v1/zones/banner/87000/tags",
  "data": {
    "async": "<script type=\"text/javascript\">if (!window.AdButler){(function(){var s = document.createElement(\"script\"); s.async = true; s.type = \"text/javascript\"; s.src = 'http://servedbyadbutler.com.baig.dev/app.js'; var n = document.getElementsByTagName(\"script\")[0]; n.parentNode.insertBefore(s, n);}());}</script>\n<script type=\"text/javascript\">\nvar AdButler = AdButler || {};\nAdButler.ads = AdButler.ads || [];\nar abkw = window.abkw || ';\nvar plc87000 = window.plc87000 || 0;\ndocument.write('<'+'div id=\"placement_87000_'+plc87000+'\"></'+'div>');\nAdButler.ads.push({handler: function(opt){ AdButler.register(107870, 87000, [120,90], 'placement_87000_'+opt.place, opt); }, opt: { place: plc87000++, keywords: abkw, domain: 'servedbyadbutler.com.baig.dev', click: CLICK_MACRO_PLACEHOLDER }});\n</script>\n<noscript>\n<a href=\"http://servedbyadbutler.com.baig.dev/go2/;ID=107870;size=120x90;setID=87000\" target=\"_blank\"><img src=\"http://servedbyadbutler.com.baig.dev/adserve/;ID=107870;size=120x90;setID=87000;type=img\" width=\"120\" height=\"90\"></a>\n</noscript>",
    "js": "<script type=\"text/javascript\">\nvar rnd = window.rnd || Math.floor(Math.random()*10e6);\nvar pid87000 = window.pid87000 || rnd;\nvar plc87000 = window.plc87000 || 0;\nvar abkw = window.abkw || ';\nvar absrc = 'http://servedbyadbutler.com.baig.dev/adserve/;ID=107870;size=120x90;setID=87000;type=js;sw='+screen.width+';sh='+screen.height+';spr='+window.devicePixelRatio+';kw='+abkw+';pid='+pid87000+';place='+(plc87000++)+';rnd='+rnd+';\ndocument.write('<scr'+'ipt src=\"'+absrc+'\" type=\"text/javascript\"></scr'+'ipt>');\n</script>\n<noscript>\n<a href=\"http://servedbyadbutler.com.baig.dev/go2/;ID=107870;size=120x90;setID=87000\" target=\"_blank\"><img src=\"http://servedbyadbutler.com.baig.dev/adserve/;ID=107870;size=120x90;setID=87000;type=img\" width=\"120\" height=\"90\"></a>\n</noscript>",
    "image": "<a href=\"http://servedbyadbutler.com.baig.dev/go2/;ID=107870;size=120x90;setID=87000\" target=\"_blank\"><img src=\"http://servedbyadbutler.com.baig.dev/adserve/;ID=107870;size=120x90;setID=87000;type=img\" width=\"120\" height=\"90\"></a>"
  }
}

and there is a typo in async key \nar abkw = window.abkw || ';, shoud be var abkw = window.abkw || ';

@baig
Copy link
Contributor

baig commented Feb 22, 2017

This is an issue with our API server code, and not an issue with the PHP library. We will be deploying the fix soon.

In the meantime, you can use the PHP library as explained in the API documentation. As soon as the fix is deployed, I will close this issue and you will see the correct async tags in the response.

Thank you for bringing this to our attention.

@baig baig closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants