Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda-forge deployment #138

Closed
4 tasks done
maxscheurer opened this issue Jan 8, 2022 · 17 comments
Closed
4 tasks done

Conda-forge deployment #138

maxscheurer opened this issue Jan 8, 2022 · 17 comments
Labels
CI Related to CI and CD

Comments

@maxscheurer
Copy link
Member

maxscheurer commented Jan 8, 2022

I'd like to test deployment of libtensorlight/adcc via conda-forge. Comments etc. can be added to this issue 😄

  • deploy libtensorlight
  • deploy adcc
  • adapt documentation and badges
  • nuke conda deployment from repo
@maxscheurer maxscheurer added the CI Related to CI and CD label Jan 8, 2022
@maxscheurer
Copy link
Member Author

libtensorlight already up on c-f ✅

@mfherbst
Copy link
Member

mfherbst commented Jan 11, 2022

Very nice. Let me know if you need to discuss something. In case there is need: I know some people from the conda-forge team I could summon.

@maxscheurer
Copy link
Member Author

I had some problems yesterday but everything is running smoothly now I guess: conda-forge/staged-recipes#17477

@maxscheurer
Copy link
Member Author

BTW I can add you as package maintainer if you want 😬

@mfherbst
Copy link
Member

mfherbst commented Jan 11, 2022

I don't have strong feelings about it. As you wish ...

@mfherbst
Copy link
Member

Why did you disable the sha256sum check by the way. I'm not sure this is a good idea.

@maxscheurer
Copy link
Member Author

maxscheurer commented Jan 11, 2022

The sha256sum (older version) on c-f VM does not support the --ignore-missing option. Maybe you have a suggestion how one could patch the script instead? 😬

@mfherbst
Copy link
Member

mfherbst commented Jan 11, 2022

I guess what you could do is "preprocess" the SHA256SUM file to only contain the files which are truely there, e.g. something like

while read line; do
     [ -f "$line" ] && echo "$line" >> SHA256SUM.filtered
done < SHA256SUM
mv SHA256SUM.filtered SHA256SUM

I guess it even makes sense to update this in adcc directly.

@maxscheurer
Copy link
Member Author

maxscheurer commented Jan 13, 2022

I'm keeping track of the next steps here (in order):

@mfherbst
Copy link
Member

upload new docs (currently online is v0.15.7)

Seriously ... that's my bad.

@maxscheurer
Copy link
Member Author

We should probably somehow discontinue the adcc channel on anaconda.org. I don't know if we should leave it up there for some "grace period"? Opinions, @mfherbst and @loriab (if you need the current adcc channel versions)?

@mfherbst
Copy link
Member

Agree, we should leave it up for some time. Perhaps we could push a last version by a manual build (?), which includes a warning upon import?

@maxscheurer
Copy link
Member Author

That's a good suggestion! Can do the manual build for 0.15.11 and upload it to the adcc channel. I would say we remove our own channel once 0.16.0 comes out.

@mfherbst
Copy link
Member

Sounds fair. That'll probably be the case when another major feature (LR-PCM ?) goes in.

@maxscheurer
Copy link
Member Author

Yes, PCM (#132) and gradients (#124) should be in 0.16.0.

@maxscheurer
Copy link
Member Author

@mfherbst if you find the time, could you push the v0.15.13 docs to the website?

@mfherbst
Copy link
Member

mfherbst commented Mar 8, 2022

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to CI and CD
Projects
None yet
Development

No branches or pull requests

2 participants