Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ham)burger problem #83

Open
PiotrGackowski opened this issue Apr 8, 2023 · 2 comments
Open

(ham)burger problem #83

PiotrGackowski opened this issue Apr 8, 2023 · 2 comments

Comments

@PiotrGackowski
Copy link
Contributor

As @andyli informed in #71 (comment) there is issue with hamburgers.

One thing is that script is checking vegan stuff - I proposed change here: #82

Second thing is that images marked by Q112156900 (vegan burger) and Q607754 (chicken burger) should not be considered for check. @addshore can you add this?

This two things are (probably) fast to fix. But there is third one. Third one is philosopical - what is hamburger. Because there is https://commons.wikimedia.org/wiki/Category:Hamburgers_by_type milion types of burgers and most of them dont contain ham. And I dont know if there is language difference between US/UK/AUS/other kinds of flavors of English language. It might be that we should turn off hamburger challenge, if we are marking as "hamburger" stuff that dont contain ham.

My edits that are reverted:

@addshore
Copy link
Owner

Looking at the burger problem, perhaps hamburger should not be used, instead just "burger"
http://www.wikidata.org/entity/Q111981894

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants