New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with Offline Mode (replaceState) #4

Closed

addyosmani opened this issue Oct 17, 2016 · 1 comment

Labels

bug

Owner

addyosmani commented Oct 17, 2016

#3 uncovered another small bug. When the Settings menu has been toggled, offline mode is

triggering this.replaceState exceptions in StoryListItem.js:

addyosmani added the bug label

Owner Author

addyosmani commented Oct 17, 2016 •

edited

Loading

Line throwing:

  initLiveItem(props) {
    if (SettingsStore.offlineMode) {
      HNServiceRest.itemRef(props.id).then(function(res) {
        return res.json()
      }).then(function(snapshot) {
        this.replaceState({ item: snapshot }) // <--
      }.bind(this))
    }

This was referenced Oct 17, 2016

Repair bug with settings (double toggle) #3

Merged

Support for replaceState preactjs/preact-compat#227

Closed

addyosmani closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment