Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Reply Doesn't work when 2 same messages are received #106

Closed
pixincreate opened this issue Feb 22, 2021 · 6 comments · Fixed by #107 or #110
Closed

Auto-Reply Doesn't work when 2 same messages are received #106

pixincreate opened this issue Feb 22, 2021 · 6 comments · Fixed by #107 or #110
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@pixincreate
Copy link
Contributor

pixincreate commented Feb 22, 2021

Yes, Auto-Reply doesn't work when you receive more than 1 message at a time. And if the messages are same, then it doesn't reply either.

Steps to re-produce:

  • Send a text(something like this - "blahh") twice on WhatsApp to the one device that you've Watomatic installed.
  • You can now see that, only message will be sent not 2. When the frequency is un-restricted.
@adeekshith
Copy link
Owner

adeekshith commented Feb 22, 2021

Hi @pixincreate Thanks for reporting this in detail.
As for the not replying for more than one messages issue, this is caused by this line:

private final int DELAY_BETWEEN_REPLY_IN_MILLISEC = 20 * 1000;

Where you can see 20*1000 ms or 20 second relax time between replies. This is causing it. This was introduced to prevent infinite loop if both users contacting each other have Watomatic enabled.

May be 20 seconds is too much. Reducing it to 10 seconds might make it unnoticeable for general users.

I can fix this in a minute but would like to ask if you would like to gain some contribution points 😃.
This is what you should do: find line 29 in this file /app/src/main/java/com/parishod/watomatic/NotificationService.java , change 20 * 1000 to 10 * 1000 and raise a pull request. Easy peasy is'nt it?

Would you like to do that as your first contribution? Let us know

@adeekshith adeekshith added good first issue Good for newcomers bug Something isn't working labels Feb 22, 2021
@pixincreate
Copy link
Contributor Author

Just created a pull request for that:)

@adeekshith adeekshith linked a pull request Feb 22, 2021 that will close this issue
@adeekshith
Copy link
Owner

Great job! 😃
Tiny change is required which I commented in the PR.

#107 (comment)

@adeekshith
Copy link
Owner

Yayy! Congrats! 🎉 Your first contribution made it to the main repo.
Will move the discussion you posted to another issue and close this one.

@adeekshith
Copy link
Owner

You should be able to see your contibutions here: contributors.
Looking forward for future contributions! Feel free to raise more issues or PRs in the future and also feel free to ask for help 😊

Moved your discussion here: #111

@adeekshith adeekshith changed the title Auto-Reply Doesn't work when 2 same messages are received and a Discussion. Auto-Reply Doesn't work when 2 same messages are received Feb 27, 2021
@adeekshith
Copy link
Owner

Attributed your fix in release notes:

Feel free to follow the page (⭐️ it or follow it) for more contributing opportunities. 😃

@spuday90 spuday90 reopened this Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
3 participants