FBT examples for React Conf Brazil 2021 #3303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbergquist-godaddy
approved these changes
Oct 16, 2021
mrtnzlml
added a commit
that referenced
this pull request
Oct 17, 2021
Fixes issue discovered here: #3303 Basically, I thought that the locale is not so important but turned out it is in some more advanced cases (FBT variations). It doesn't affect any of our applications using FBT, but I'd like to change it anyway to prevent future confusion. Unfortunately, I don't know how to easily test it without creating a fake translation dictionary.
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 18, 2021
Fixes issue discovered here: #3303 Basically, I thought that the locale is not so important but turned out it is in some more advanced cases (FBT variations). It doesn't affect any of our applications using FBT, but I'd like to change it anyway to prevent future confusion. Unfortunately, I don't know how to easily test it without creating a fake translation dictionary.
adeira-github-bot
pushed a commit
to mrtnzlml-archive/kochka.com.mx
that referenced
this pull request
Oct 18, 2021
Fixes issue discovered here: adeira/universe#3303 Basically, I thought that the locale is not so important but turned out it is in some more advanced cases (FBT variations). It doesn't affect any of our applications using FBT, but I'd like to change it anyway to prevent future confusion. Unfortunately, I don't know how to easily test it without creating a fake translation dictionary. adeira-source-id: 4887556bc587c821ff8d08403e3f3a2f0027e211
adeira-github-bot
pushed a commit
to adeira/sx-design
that referenced
this pull request
Oct 18, 2021
Fixes issue discovered here: adeira/universe#3303 Basically, I thought that the locale is not so important but turned out it is in some more advanced cases (FBT variations). It doesn't affect any of our applications using FBT, but I'd like to change it anyway to prevent future confusion. Unfortunately, I don't know how to easily test it without creating a fake translation dictionary. adeira-source-id: 4887556bc587c821ff8d08403e3f3a2f0027e211
This commit is not to be merged! It exists just for education purposes. To run this example you have to clone this repository and then install dependencies via Yarn: ```text yarn install ``` Finally, from the repo root you can run the Storybook (open `ReactConfBrasil` component): ```text yarn workspace @adeira/sx-design storybook ``` The most important file you have to look at is `src/sx-design/src/ReactConfBrasil/ReactConfBrasil.js`. Rest of the changes can be ignored as it is not important for this demo. You can follow these examples and dive a bit deeper here: https://mrtnzlml.com/docs/fbt - Conf: https://reactconf.com.br/ - FBT docs: https://facebook.github.io/fbt/
mrtnzlml
force-pushed
the
ReactConfBrasil_2021
branch
from
5748e3f
to
3f6daa0
Compare
|
Closing because it served the purpose. ✅ |
adeira-github-bot
pushed a commit
to adeira/abacus-backoffice
that referenced
this pull request
Jan 29, 2022
Fixes issue discovered here: adeira/universe#3303 Basically, I thought that the locale is not so important but turned out it is in some more advanced cases (FBT variations). It doesn't affect any of our applications using FBT, but I'd like to change it anyway to prevent future confusion. Unfortunately, I don't know how to easily test it without creating a fake translation dictionary. adeira-source-id: 4887556bc587c821ff8d08403e3f3a2f0027e211
adeira-github-bot
pushed a commit
to adeira/abacus-kochka
that referenced
this pull request
Jan 29, 2022
Fixes issue discovered here: adeira/universe#3303 Basically, I thought that the locale is not so important but turned out it is in some more advanced cases (FBT variations). It doesn't affect any of our applications using FBT, but I'd like to change it anyway to prevent future confusion. Unfortunately, I don't know how to easily test it without creating a fake translation dictionary. adeira-source-id: 4887556bc587c821ff8d08403e3f3a2f0027e211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is not to be merged! It exists just for education purposes. To run this example you have to clone this repository and then install dependencies via Yarn:
Finally, from the repo root you can run the Storybook (open
ReactConfBrasilcomponent):The most important file you have to look at is
src/sx-design/src/ReactConfBrasil/ReactConfBrasil.js. Rest of the changes can be ignored as it is not important for this demo.You can follow these examples and dive a bit deeper here: https://mrtnzlml.com/docs/fbt